Generate v1 files from latest beta versions

[mauriciopoppe]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind feature

What this PR does / why we need it:

Generates v1 API files for client/api/{disk,filesystem,smb,volume}, summary of changes:

• I copied the beta folders to v1, regenerated the proto & _generated.go files with make clean and make generate
• I updated the integration tests & unit tests to use the v1 dir
• Also had to force push the v1 files from the vendor directory

/cc @jingxu97

Does this PR introduce a user-facing change?:

v1 API version bump for Disk, Volume, FileSystem and SMB API groups

[k8s-ci-robot]

Welcome @mauriciopoppe!

It looks like this is your first PR to kubernetes-csi/csi-proxy 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-proxy has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @mauriciopoppe. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mauriciopoppe]

/cc @ddebroy
I followed #76

[jingxu97]

/ok-to-test

[mauriciopoppe]

@jingxu97 @ddebroy the vendor folder has a reference to this repository i.e. to github.com/kubernetes-csi/csi-proxy, is this correct?

[ddebroy]

hey @jingxu97 I know you introduced the vendor directory in #82 and that included the csi-proxy code itself there as well. Do you recall why we need the csi-proxy files in vendor however?

[ddebroy]

sorry for the late review. @mauriciopoppe one q I had was are the renaming of the client_generated.go files for the different API groups like: https://github.com/kubernetes-csi/csi-proxy/pull/120/files#diff-9462bc31a89a73f4209384d57c5e6728708a03d7e03d4f2a80e250e2893f887c . Those should be just fresh new files for v1 (as in https://github.com/kubernetes-csi/csi-proxy/tree/master/client/groups/disk for example). Can you please double check that? Otherwise LGTM.

[mauriciopoppe]

got it, I see the following in my editor

but I also see that it shows as renamed in github, I'll check it

[mauriciopoppe]

It looks like git thinks that a vendor file was renamed to the v1 file

The vendor files for the usage of v1beta1 and v1beta2 are gone (I regenerated them with go mod vendor), I checked the branch for the autogenerated files and both v1beta and v1 are there, so I think we're good :)

[mauriciopoppe]

@ddebroy I found out that client/ is a go module, there's a detailed PR about the why here #7 (to prove this I removed the go.{mod,sum} files in client/ and run go mod vendor and there were no references in vendor/ to client/) it's a nested module other directories must include and this was done through replace

It looks like the line

csi-proxy/go.mod

Line 6 in cf66b05

github.com/kubernetes-csi/csi-proxy/client => ./client

can't be removed, because the source code files are now using the v1 api some references to v1betaX were removed from modules.txt

I also looked at the issue about git thinking that a rename happened instead of a code generation, I think this is answered in https://stackoverflow.com/a/15031787/3341726 and it's how diffs are displayed, I run the following to check which files were actually renamed and there are none:

❯ git diff --name-status --no-renames master
A       client/api/disk/v1/api.pb.go
A       client/api/disk/v1/api.proto
A       client/api/filesystem/v1/api.pb.go
A       client/api/filesystem/v1/api.proto
A       client/api/smb/v1/api.pb.go
A       client/api/smb/v1/api.proto
A       client/api/volume/v1/api.pb.go
A       client/api/volume/v1/api.proto
A       client/groups/disk/v1/client_generated.go
A       client/groups/filesystem/v1/client_generated.go
A       client/groups/smb/v1/client_generated.go
A       client/groups/volume/v1/client_generated.go
M       go.mod
M       go.sum
M       integrationtests/disk_test.go
M       integrationtests/filesystem_test.go
A       client/api/disk/v1/api.pb.go
A       client/api/disk/v1/api.proto
A       client/api/filesystem/v1/api.pb.go
A       client/api/filesystem/v1/api.proto
A       client/api/smb/v1/api.pb.go
A       client/api/smb/v1/api.proto
A       client/api/volume/v1/api.pb.go
A       client/api/volume/v1/api.proto
A       client/groups/disk/v1/client_generated.go
A       client/groups/filesystem/v1/client_generated.go
A       client/groups/smb/v1/client_generated.go
A       client/groups/volume/v1/client_generated.go
M       go.mod
M       go.sum
M       integrationtests/disk_test.go
M       integrationtests/filesystem_test.go
M       integrationtests/iscsi_test.go
M       integrationtests/smb_test.go
M       integrationtests/volume_test.go
M       internal/server/disk/api_group_generated.go
A       internal/server/disk/internal/v1/conversion.go
A       internal/server/disk/internal/v1/conversion_generated.go
A       internal/server/disk/internal/v1/server_generated.go
M       internal/server/filesystem/api_group_generated.go
A       internal/server/filesystem/internal/v1/conversion.go
A       internal/server/filesystem/internal/v1/conversion_generated.go
A       internal/server/filesystem/internal/v1/server_generated.go
M       internal/server/filesystem/server_test.go
M       internal/server/smb/api_group_generated.go
A       internal/server/smb/internal/v1/conversion.go
A       internal/server/smb/internal/v1/conversion_generated.go
A       internal/server/smb/internal/v1/server_generated.go
M       internal/server/smb/server_test.go
M       internal/server/volume/api_group_generated.go
A       internal/server/volume/internal/v1/conversion.go
A       internal/server/volume/internal/v1/conversion_generated.go
A       internal/server/volume/internal/v1/server_generated.go
M       internal/server/volume/server_test.go
M       release-tools/README.md
M       release-tools/build.make
M       release-tools/cloudbuild.yaml
M       release-tools/prow.sh
D       release-tools/travis.yml
M       release-tools/verify-go-version.sh
A       vendor/github.com/kubernetes-csi/csi-proxy/client/api/disk/v1/api.pb.go
A       vendor/github.com/kubernetes-csi/csi-proxy/client/api/disk/v1/api.proto

Anyways it looks like it's just a git diff thing, not a codebase problem

[ddebroy]

Thanks for double checking that @mauriciopoppe
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddebroy, mauriciopoppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ddebroy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment