Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates in the SMB v1beta2 API #132

Closed
mauriciopoppe opened this issue May 4, 2021 · 0 comments · Fixed by #146
Closed

Updates in the SMB v1beta2 API #132

mauriciopoppe opened this issue May 4, 2021 · 0 comments · Fixed by #146

Comments

@mauriciopoppe
Copy link
Member

mauriciopoppe commented May 4, 2021 •
edited
Loading

API Changes:

  • Change all parameters from camelCase to underscores e.g. diskNumber -> disk_number
  • Remove string error=1 from all the messages
  • Make sure that the comments match what the api does

Also:
@mauriciopoppe mauriciopoppe mentioned this issue May 5, 2021
Merged
pohly added a commit to pohly/csi-proxy that referenced this issue May 5, 2021
@pohly
Squashed 'release-tools/' changes from 1d60e77..7bc70e5
cc46559 
7bc70e5 Merge pull request kubernetes-csi#129 from pohly/squash-documentation
e0b02e7 README.md: document usage of --squash
316cb95 Merge pull request kubernetes-csi#132 from yiyang5055/bugfix/boilerplate
26e2ab1 fix: default boilerplate path
1add8c1 Merge pull request kubernetes-csi#133 from pohly/kubernetes-1.20-tag
3e811d6 prow.sh: fix "on-master" prow jobs

git-subtree-dir: release-tools
git-subtree-split: 7bc70e5264a5ce5f47780bdbc6c7b7f4e79243fa
@ddebroy ddebroy mentioned this issue May 13, 2021
Merged
@mauriciopoppe mauriciopoppe changed the title Updates in the SMB API Updates in the SMB v1beta2 API May 26, 2021
@mauriciopoppe mauriciopoppe mentioned this issue Jun 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes in the SMB v1beta2 API mauriciopoppe/csi-proxy
1 participant
@mauriciopoppe