Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates in the Volume v1beta3 API #130

Closed
mauriciopoppe opened this issue May 4, 2021 · 1 comment · Fixed by #138
Closed

Updates in the Volume v1beta3 API #130

mauriciopoppe opened this issue May 4, 2021 · 1 comment · Fixed by #138
Assignees

Comments

@mauriciopoppe
Copy link
Member

mauriciopoppe commented May 4, 2021

API Changes

  • Change all parameters from camelCase to underscores e.g. diskNumber -> disk_number
  • Make sure that the comments match what the api does
  • ListVolumesOnDisk to support multiple partition case, need to add parameters related to partition e.g. send another parameter called partition_number
  • Use disk number instead of ID, also change from string to int64
  • Change DismountVolume to UnmountVolume (TODO: confirm this change)
  • Change path to target_path in MountVolume and UnmountVolume
  • isVolumeFormatted: Update comment to “checks if a volume is formatted.”
  • FormatVolume: update comment to “formats a volume with NTFS.”
  • ResizeVolume: change size to size_bytes
  • VolumeStats: GetVolumeStats, also change the request and response to GetVolumeStatsRequest and GetVolumeStatsResponse
  • VolumeStatsResponse: volumeSize to total_bytes and volumeUsedSize to used_bytes https://github.com/container-storage-interface/spec/blob/da58351ba3d7baf850877be3425e76ff30645d33/csi.proto#L1410-L1430
  • Change GetVolumeDiskNumber to GetDiskNumberFromVolumeID, also change GetDiskNumberFromVolumeIDRequest and GetDiskNumberFromVolumeIDResponse
  • VolumeIDFromMountRequest to VolumeIDFromTargetPathRequest Change, change the parameter to target_path
  • WriteVolumeCache -- update comment to “Writes the file system cache to disk with the given volume id”

Also:

@mauriciopoppe
Copy link
Member Author

/assign @mauriciopoppe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant