Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vendor folder #82

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Add vendor folder #82

merged 1 commit into from
Oct 2, 2020

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Sep 30, 2020 •
edited
Loading

add vendor folder

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@jingxu97
Add vendor folder
f28d7f5 
add vendor folder
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 30, 2020
@jingxu97
Copy link
Contributor Author

/assign @ddebroy

@jingxu97
Copy link
Contributor Author

jingxu97 commented Oct 1, 2020

cc @msau42

ddebroy
ddebroy reviewed Oct 1, 2020
View reviewed changes
Copy link
Contributor

@ddebroy ddebroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jingxu97 is the vendor/modules.txt file missing? https://golang.org/ref/mod#vendoring

@jingxu97
Copy link
Contributor Author

jingxu97 commented Oct 1, 2020

@jingxu97 is the vendor/modules.txt file missing? https://golang.org/ref/mod#vendoring

I checked, it is included?
https://github.com/kubernetes-csi/csi-proxy/blob/f28d7f58f3f25687173e4c13cb2b87de9cef2ed2/vendor/modules.txt

@ddebroy
Copy link
Contributor

ddebroy commented Oct 2, 2020 •
edited
Loading

Sorry missed that - indeed vendor/modules.txt it is already there.

@ddebroy
Copy link
Contributor

ddebroy commented Oct 2, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 897abed into kubernetes-csi:master Oct 2, 2020
@ddebroy ddebroy mentioned this pull request Mar 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddebroy ddebroy ddebroy left review comments

@kkmsft kkmsft Awaiting requested review from kkmsft

@msau42 msau42 Awaiting requested review from msau42

Assignees

@ddebroy ddebroy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jingxu97 @k8s-ci-robot @ddebroy