Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #987

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Update README.md #987

merged 1 commit into from
Mar 12, 2019

Conversation

xcoulon
Copy link
Contributor

@xcoulon xcoulon commented Mar 12, 2019

Proposed Changes

  • Fixed a minor typo

Fixed a minor typo
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 12, 2019
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2019
@samodell
Copy link
Contributor

/ok-to-test
/approve
/lgtm

Thanks for your PR!

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samodell, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 3f5b673 into knative:master Mar 12, 2019
vorburger added a commit to vorburger/docs that referenced this pull request Mar 19, 2019
* master:
  fix serving directory path (knative#1015)
  site: insert 'docs' container folder at root (for knative.dev) (knative#1007)
  hack: update ref docs gen script to cleanup tmp dirs (knative#1001)
  hack: configurable repo refs for api docs gen (knative#998)
  Update traffic splitting example to use Release mode (knative#964)
  Update Eventing cronjob-source for Cloudevents (knative#1006)
  Update issue templates -- delete extra template, add security note (knative#1003)
  Update issue templates -- separate feature request from new/changing functionality (knative#1002)
  Clarifying Docs contributor roles (knative#958)
  update OpenShift on install (knative#975)
  Update the monitoring file version (knative#996)
  Update Dockerfile (knative#991)
  update Knative-with-OpenShift from 3.10 to 3.11 (and minor clean up) (knative#974)
  make install/scripts/knative-with-openshift.sh +x and -e (knative#973)
  fix wrong path (knative#989)
  Update README.md (knative#987)
  Change MiniKube installation to require 1.12 cluster. (knative#873)
  fix typo (knative#963)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants