Clarifying Docs contributor roles #958
Conversation
samodell
added
the
do-not-merge/work-in-progress
knative-prow-robot
removed
the
do-not-merge/work-in-progress
knative-prow-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: samodell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
community/DOCS-CONTRIBUTING.md
Outdated
| - Has made multiple contributions to the project or community. Contributions may | ||
| include, but are not limited to: | ||
|
|
||
| - Authoring or reviewing PRs on GitHub in Knative/Docs or Knative/Website |
There was a problem hiding this comment.
Should the repo paths be capitalized? I think of them as lower-case, but I think just because that's how they appear in URLs.
Also, global comment that I think these bullets should have periods at the end of them. Looks like this guidance is applied in some cases, but not in others.
community/DOCS-CONTRIBUTING.md
Outdated
|
|
||
| ### Requirements | ||
|
|
||
| - Reviewer of the Docs repo for at least 3 months or 50% of project lifetime, |
There was a problem hiding this comment.
Is the project here Knative itself? I think we're at the 8 month mark (so 50% of project lifetime is 4 mos?), so maybe just hae the at least 3 months requirement?
community/DOCS-CONTRIBUTING.md
Outdated
|
|
||
| Once you feel you meet the criteria, you can ask one of the current | ||
| approvers to nominate you to become an approver. If all existing | ||
| approvers agree that you meet the criteria, and no one objects, |
There was a problem hiding this comment.
Don't think we need the phrase "and no one objects" - feels repetitive.
| approvers agree that you meet the criteria, and no one objects, | |
| approvers agree that you meet the criteria, |
Co-Authored-By: samodell <[email protected]>
The text in DOCS-CONTRIBUTING was pulled from ROLES, so I'm making the same changes here as I did there.
|
@carieshmarie Addressed your comments; PTAL! :) |
|
|
||
| - Addresses bugs or issues in their documentation in a timely manner. | ||
|
|
||
| ### Becoming a member |
There was a problem hiding this comment.
Good to see this section, thanks @samodell , this really helps ;-)
/lgtm
|
Oops, @carieshmarie this merged in before you could review my changes. Please let me know if there are any leftover concerns and I'll open a new PR to address. |
|
Sorry @samodell and @carieshmarie , I will try to use |
* master: fix serving directory path (knative#1015) site: insert 'docs' container folder at root (for knative.dev) (knative#1007) hack: update ref docs gen script to cleanup tmp dirs (knative#1001) hack: configurable repo refs for api docs gen (knative#998) Update traffic splitting example to use Release mode (knative#964) Update Eventing cronjob-source for Cloudevents (knative#1006) Update issue templates -- delete extra template, add security note (knative#1003) Update issue templates -- separate feature request from new/changing functionality (knative#1002) Clarifying Docs contributor roles (knative#958) update OpenShift on install (knative#975) Update the monitoring file version (knative#996) Update Dockerfile (knative#991) update Knative-with-OpenShift from 3.10 to 3.11 (and minor clean up) (knative#974) make install/scripts/knative-with-openshift.sh +x and -e (knative#973) fix wrong path (knative#989) Update README.md (knative#987) Change MiniKube installation to require 1.12 cluster. (knative#873) fix typo (knative#963)
No description provided.