Update Eventing cronjob-source for Cloudevents #1006
Conversation
Updates the documentation for cronjob-source sample to latest output. Output has changed due to the adoption of cloudevents.io by eventing.
knative-prow-robot
added
size/S
|
/ok-to-test |
knative-prow-robot
added
lgtm
| Host: message-dumper.default.svc.cluster.local | ||
| Transfer-Encoding: chunked | ||
| Accept-Encoding: gzip | ||
| Ce-Cloudeventsversion: 0.1 |
There was a problem hiding this comment.
BTW: In the next release it will use 0.2.
There was a problem hiding this comment.
Thanks for the heads-up.
There was a problem hiding this comment.
I should dig out my code to switch this from something which dumps HTTP to something which dumps CloudEvents, since I think we want people talking about attributes/body, rather than HTTP framing.
But, this is correct at the moment, so let's get it in.
|
/lgtm |
| Host: message-dumper.default.svc.cluster.local | ||
| Transfer-Encoding: chunked | ||
| Accept-Encoding: gzip | ||
| Ce-Cloudeventsversion: 0.1 |
There was a problem hiding this comment.
I should dig out my code to switch this from something which dumps HTTP to something which dumps CloudEvents, since I think we want people talking about attributes/body, rather than HTTP framing.
But, this is correct at the moment, so let's get it in.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, khrm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* master: fix serving directory path (knative#1015) site: insert 'docs' container folder at root (for knative.dev) (knative#1007) hack: update ref docs gen script to cleanup tmp dirs (knative#1001) hack: configurable repo refs for api docs gen (knative#998) Update traffic splitting example to use Release mode (knative#964) Update Eventing cronjob-source for Cloudevents (knative#1006) Update issue templates -- delete extra template, add security note (knative#1003) Update issue templates -- separate feature request from new/changing functionality (knative#1002) Clarifying Docs contributor roles (knative#958) update OpenShift on install (knative#975) Update the monitoring file version (knative#996) Update Dockerfile (knative#991) update Knative-with-OpenShift from 3.10 to 3.11 (and minor clean up) (knative#974) make install/scripts/knative-with-openshift.sh +x and -e (knative#973) fix wrong path (knative#989) Update README.md (knative#987) Change MiniKube installation to require 1.12 cluster. (knative#873) fix typo (knative#963)
Updates the documentation for cronjob-source sample to show latest output.
Fixes #1005
Proposed Changes