make install/scripts/knative-with-openshift.sh +x and -e #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
size/XS
|
/ok-to-test |
knative-prow-robot
added
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: samodell, vorburger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vorburger
added a commit
to vorburger/docs
that referenced
this pull request
Mar 19, 2019
* master: fix serving directory path (knative#1015) site: insert 'docs' container folder at root (for knative.dev) (knative#1007) hack: update ref docs gen script to cleanup tmp dirs (knative#1001) hack: configurable repo refs for api docs gen (knative#998) Update traffic splitting example to use Release mode (knative#964) Update Eventing cronjob-source for Cloudevents (knative#1006) Update issue templates -- delete extra template, add security note (knative#1003) Update issue templates -- separate feature request from new/changing functionality (knative#1002) Clarifying Docs contributor roles (knative#958) update OpenShift on install (knative#975) Update the monitoring file version (knative#996) Update Dockerfile (knative#991) update Knative-with-OpenShift from 3.10 to 3.11 (and minor clean up) (knative#974) make install/scripts/knative-with-openshift.sh +x and -e (knative#973) fix wrong path (knative#989) Update README.md (knative#987) Change MiniKube installation to require 1.12 cluster. (knative#873) fix typo (knative#963)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.