Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onPaste separator logic in KeyValue.vue #1012

Merged
merged 1 commit into from
May 6, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented May 6, 2024

Summary

In Images -> Create -> Labels, follow the tooltip Paste lines of key=value or key:value into any key field for easy bulk entry and try to paste key=value lines, but not convert to lables automatically.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Fixes # harvester/harvester#4206

Technical notes summary

KeyValue.vue natively have onPaste logic l to convert multi-lines into key:value map.
But have error logic to support : separator.

Screenshot/Video

Check this change also fix

  • Virtual Machine -> Create ✅
  • Network -> Load Balancer -> Create ✅
  • Image -> Create ✅

e.g. paste in key field

user-firstname=Andy Lee 
user-lastname=aaa
user-id:123
Screenshot 2024-05-05 at 10 07 51 PM

@a110605 a110605 requested a review from torchiaf May 6, 2024 02:08
@a110605 a110605 changed the title fix: onPaste separate logic in KeyValue.vue fix: onPaste separator logic in KeyValue.vue May 6, 2024
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torchiaf
Copy link
Collaborator

torchiaf commented May 6, 2024

@a110605 Could you please open a new issue for porting in Rancher dashboard ?

@torchiaf torchiaf mentioned this pull request May 6, 2024
3 tasks
@a110605 a110605 merged commit 4c53b5f into harvester:master May 6, 2024
7 checks passed
@a110605
Copy link
Collaborator Author

a110605 commented May 7, 2024

@a110605 Could you please open a new issue for porting in Rancher dashboard ?

Opened in rancher/dashboard : rancher#10958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants