Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mode input to labels fields #1013

Merged
merged 1 commit into from
May 7, 2024
Merged

Add mode input to labels fields #1013

merged 1 commit into from
May 7, 2024

Conversation

torchiaf
Copy link
Collaborator

@torchiaf torchiaf commented May 6, 2024 •
edited
Loading

Summary

Blocked by #1012

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Occurred changes and/or fixed issues

Technical notes summary

The label fields should be disabled in Config view

Screenshot/Video

image

@torchiaf torchiaf requested a review from a110605 May 6, 2024 10:38
@torchiaf torchiaf removed their assignment May 6, 2024
@torchiaf
Add mode input to labels fields
75ab29c 
Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf torchiaf force-pushed the fix-image-labels branch from 58b4b78 to 75ab29c Compare May 6, 2024 13:56
a110605
a110605 approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@torchiaf torchiaf merged commit 4415f05 into harvester:master May 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a110605 a110605 a110605 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torchiaf @a110605