Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Image label "easy bulk entry" seems not work #4206

Closed
albinsun opened this issue Jul 9, 2023 · 4 comments
Closed

[BUG] Image label "easy bulk entry" seems not work #4206

albinsun opened this issue Jul 9, 2023 · 4 comments
Assignees
Labels
area/ui Harvester UI kind/bug Issues that are defects reported by users or that we know have reached a real release reproduce/always Reproducible 100% of the time severity/3 Function working but has a major issue w/ workaround
Milestone

Comments

@albinsun
Copy link

albinsun commented Jul 9, 2023

Describe the bug
In Images -> Create -> Labels, follow the tooltip Paste lines of key=value or key: value into any key field for easy bulk entry and try to paste key=value lines, but not convert to lables automatically.
image

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Images -> Create'

  2. In Basics, enter image URL, image Name is filled automatically.

    image

  3. In Labels, enter custom key=value lines, but not convert to labels.

    • Content
      user-firstname=John
      user-lastname=Doe
      user-id=123
      
    • lines does not convert to lables
      image

Expected behavior
lines should be convert to lables like:

Key Value
user-firstname John
user-lastname Doe
user-id 123

Support bundle
supportbundle-easy_bulk_entry_labels.zip

Environment

  • Harvester ISO version: v1.2.0-rc3
  • Underlying Infrastructure: QEMU/KVM, 3 nodes (8cores/16GB/250G)

Additional context

  1. Reference: https://docs.harvesterhci.io/v1.1/upload-image#image-labels
  2. No explicit error in dev tool
    image
@albinsun albinsun added kind/bug Issues that are defects reported by users or that we know have reached a real release severity/4 Function working but has a minor issue (a minor incident with low impact) reproduce/always Reproducible 100% of the time area/ui Harvester UI severity/2 Function working but has a major issue w/o workaround (a major incident with significant impact) severity/3 Function working but has a major issue w/ workaround and removed severity/2 Function working but has a major issue w/o workaround (a major incident with significant impact) severity/3 Function working but has a major issue w/ workaround severity/4 Function working but has a minor issue (a minor incident with low impact) labels Jul 9, 2023
@WuJun2016 WuJun2016 added this to the v1.3.0 milestone Aug 8, 2023
@bk201 bk201 modified the milestones: v1.3.0, v1.4.0 Feb 20, 2024
@bk201 bk201 assigned torchiaf and unassigned WuJun2016 Feb 20, 2024
@torchiaf torchiaf removed their assignment Apr 22, 2024
@a110605 a110605 self-assigned this Apr 22, 2024
@a110605
Copy link

a110605 commented May 2, 2024

Same issue also happened in pages

  • Virtual Machine -> Create
  • Network -> Load Balancer -> Create
    label-instance

There is logic bug during parsing the separator. (code)

Since the code is from rancher shell, same issue happened on rancher dashboard.

@harvesterhci-io-github-bot
Copy link
Collaborator

Pre Ready-For-Testing Checklist

  • If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
    The HEP PR is at:

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
    The PR is at:

    • Does the PR include the explanation for the fix or the feature?

    • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
      The PR for the YAML change is at:
      The PR for the chart change is at:

  • If labeled: area/ui Has the UI issue filed or ready to be merged?
    The UI issue/PR is at:

  • If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
    The documentation/KB PR is at:

  • If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

    • The automation skeleton PR is at:
    • The automation test case PR is at:
  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at:

@harvesterhci-io-github-bot
Copy link
Collaborator

Automation e2e test issue: harvester/tests#1252

@irishgordo
Copy link
Contributor

@a110605 this looks good on Harvester Version: master-9c0a3a1-head 👍 😄
I'll go ahead and close it out

easybulkentry-2024-07-03_17.00.15.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Harvester UI kind/bug Issues that are defects reported by users or that we know have reached a real release reproduce/always Reproducible 100% of the time severity/3 Function working but has a major issue w/ workaround
Projects
None yet
Development

No branches or pull requests

7 participants