Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] label key field doesn't support colon as separator #10958

Open
a110605 opened this issue May 7, 2024 · 2 comments
Open

[BUG] label key field doesn't support colon as separator #10958

a110605 opened this issue May 7, 2024 · 2 comments
Assignees
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@a110605
Copy link
Contributor

a110605 commented May 7, 2024

Setup

  • Rancher version: v2.8.3
  • Rancher UI Extensions:
  • Browser type & version: Chrome latest

Describe the bug
The pasted context doesn't support : as separator, but support =
The tooltip said Paste lines of key=value or key: value into any key field for easy bulk entry

To Reproduce

  1. Go to Continuous Delivery -> Workspace -> Create
  2. Add Labels
  3. paste below text in key field
user-firstname: Andy Lee 
user-lastname: aaa
user-id: 123

Result
The text doesn't parse to key and value.

Screenshot 2024-05-07 at 2 20 06 PM

Expected Result
The text should be parsed to key and value.

Screenshots

@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label May 7, 2024
@a110605 a110605 changed the title <bug title: summarize bug in one line> Label key field doesn't support colon as separator May 7, 2024
@a110605 a110605 self-assigned this May 7, 2024
@a110605 a110605 changed the title Label key field doesn't support colon as separator [BUG] label key field doesn't support colon as separator May 7, 2024
@a110605 a110605 added this to the Project milestone May 7, 2024
@nwmac nwmac modified the milestones: Project, v2.9.0 May 7, 2024
@gaktive
Copy link
Member

gaktive commented May 29, 2024

We may need to think about this more because : could exist in the key name. There's also the chance that folks could mix = and : together in the same YAML so we'd need better parsing overall (e.g, if no equal signs, assume colon) and then sort out escape characters.

Pushing to 2.10 so we can come up with a strategy.

@gaktive gaktive modified the milestones: v2.9.0, v2.10.0 May 29, 2024
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Jul 4, 2024
@richard-cox
Copy link
Member

The key name can't have a : (https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set), though it's not required and it could be in the value (to confirm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

No branches or pull requests

4 participants