OTLP receiver: Convert start timestamps to Prometheus zero samples #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
arve/otlp-starttime
branch
2 times, most recently
from
6473206 to
b4b3894
Compare
4 tasks
jesusvazquez
force-pushed
the
arve/otlp-starttime
branch
from
b4b3894 to
fedafd7
Compare
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
jesusvazquez
force-pushed
the
arve/otlp-starttime
branch
from
7ded0f6 to
12be21d
Compare
bboreham
approved these changes
Aug 30, 2024
Comment on lines
7
to
+9
| * [BUGFIX] tsdb/wlog.Watcher.readSegmentForGC: Only count unknown record types against record_decode_failures_total metric. #14042 | ||
| * [ENHANCEMENT] OTLP: During translation, check for context cancellation/timeout. #654 | ||
| * [ENHANCEMENT] OTLP receiver: If the feature flag `--created-timestamp-zero-ingestion` is true, convert OTel start timestamps to Prometheus zero samples. #14759 |
There was a problem hiding this comment.
Enhancements should all group together, but we can fix that in post.
Merged
This was referenced Sep 5, 2024
julienduchesne
added a commit
that referenced
this pull request
Jan 8, 2025
…chesne/upstream-pt2 Conflicts: - api/v1/errors_test.go: #706 with prometheus/prometheus@3b97a63 - web/api/v1/api.go: #684 with prometheus/prometheus@3b97a63. Picked the upstream naming for the parameter (`enableCTZeroIngestion` vs `ctZeroIngestionEnabled`)
julienduchesne
added a commit
that referenced
this pull request
Jan 8, 2025
…chesne/upstream-pt2 Conflicts: - api/v1/errors_test.go: #706 with prometheus/prometheus@3b97a63 - web/api/v1/api.go: #684 with prometheus/prometheus@3b97a63. Picked the upstream naming for the parameter (`enableCTZeroIngestion` vs `ctZeroIngestionEnabled`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the OTLP receiver to, if the
--created-timestamp-zero-ingestionfeature flag is true, convert data point start timestamps to Prometheus zero samples 1 millisecond before the sample itself, iff the following is true: The OTel start timestamp is greater than zero and equal to the data point timestamp.Depends on #685.