Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync upstream to 9823a93c4238b3b549321ece051bbba6d3922741 #816

Merged
merged 20 commits into from
Jan 8, 2025

Conversation

beorn7 and others added 19 commits December 20, 2024 11:19
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Instead of storing discovered labels on every target, recompute them if
required. The `Target` struct now needs to hold some more data required
to recompute them, such as ScrapeConfig.

This moves the load from every Prometheus all of the time, to just when
someone views Service Discovery in the UI.

The way `PopulateLabels` is used changes; you are no longer expected to
call it with a part-populated `labels.Builder`.

The signature of `Target.Labels` changes to take a `labels.Builder`
instead of a `ScratchBuilder`, for consistency with `DiscoveredLabels`.

This will save a lot of work when many targets are filtered out in
relabeling. Combine with `keep_dropped_targets` to avoid ever computing
most labels for dropped targets.

Signed-off-by: Bryan Boreham <[email protected]>
OTLP receiver: Allow colons in non-standard units
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.27.5 to 3.27.7.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@f09c1c0...babb554)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 4.1.2 to 4.2.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@6849a64...1bd1e32)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…15580)

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@41dfa10...3041bf5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Exported the CheckpointPrefix constant to be used in other packages.
Updated references to the constant in db.go and checkpoint.go files.
This change improves code readability and maintainability.

Signed-off-by: johncming <[email protected]>
Co-authored-by: johncming <[email protected]>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@41dfa10...3041bf5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…o no longer be in use.

partially reverts prometheus/prometheus#14064

fixes prometheus/prometheus#15232

supersedes prometheus/prometheus#15533

reusing Engine.Close() outside of tests will require more consideration.

Signed-off-by: machine424 <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Jan 8, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 7 committers have signed the CLA.

✅ aknuds1
✅ bboreham
✅ beorn7
✅ pinglanlu
❌ machine424
❌ johncming
❌ bwplotka
You have signed the CLA already but the status is still pending? Let us recheck it.

…chesne/upstream-pt2

Conflicts:
- api/v1/errors_test.go: #706 with prometheus/prometheus@3b97a63
- web/api/v1/api.go: #684 with prometheus/prometheus@3b97a63. Picked the upstream naming for the parameter (`enableCTZeroIngestion` vs `ctZeroIngestionEnabled`)
@julienduchesne julienduchesne force-pushed the julienduchesne/upstream-pt2 branch from a43e554 to ec81cca Compare January 8, 2025 17:26
@julienduchesne julienduchesne marked this pull request as ready for review January 8, 2025 17:30
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see one change that looks off.

template/template.go Show resolved Hide resolved
@julienduchesne julienduchesne merged commit 236cc08 into main Jan 8, 2025
7 of 8 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/upstream-pt2 branch January 8, 2025 18:06
@pinglanlu
Copy link
Contributor

Signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants