OTLP: Increase valid created timestamp threshold to 5 minutes #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increasing valid threshold for inserting zero's at StartTimeUnixNano on OTLP Write requests. The reason why we want to do this is that Grafana's $__rate_interval is typically 4 times the scrape interval so assuming an average DPM of 1 we could have the zero sample 4 minutes before the first sample. This is a small change that might help with usecases where samples are slightly delayed. Also we've made this threshold configurable now. It defaults to 5 minutes but it can be overiden for special cases. Signed-off-by: Jesus Vazquez <[email protected]>
jesusvazquez
force-pushed
the
jvp/otlp-ct-zero-timestamp-update
branch
from
8a97e0b to
ce7e117
Compare
Signed-off-by: Jesus Vazquez <[email protected]>
krajorama
reviewed
Oct 3, 2024
storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Jesus Vazquez <[email protected]>
krajorama
approved these changes
Oct 3, 2024
web/web.go
Outdated
Comment on lines
265
to
266
| EnableCreatedTimestampZeroIngestion bool | ||
| ValidIntervalCreatedTimestampZeroIngestion time.Duration |
There was a problem hiding this comment.
nit: these two cause conflicts when updating from upstream due to the indenting. Would be nice to eventually clean these up by adding our additions at the end after empty line
There was a problem hiding this comment.
You mean something like:
RemoteReadBytesInFrame int
EnableRemoteWriteReceiver bool
EnableOTLPWriteReceiver bool
// Our additions
EnableCreatedTimestampZeroIngestion bool
ValidIntervalCreatedTimestampZeroIngestion time.Duration
julienduchesne
added a commit
that referenced
this pull request
Jan 8, 2025
…chesne/upstream-pt2 Conflicts: - api/v1/errors_test.go: #706 with prometheus/prometheus@3b97a63 - web/api/v1/api.go: #684 with prometheus/prometheus@3b97a63. Picked the upstream naming for the parameter (`enableCTZeroIngestion` vs `ctZeroIngestionEnabled`)
julienduchesne
added a commit
that referenced
this pull request
Jan 8, 2025
…chesne/upstream-pt2 Conflicts: - api/v1/errors_test.go: #706 with prometheus/prometheus@3b97a63 - web/api/v1/api.go: #684 with prometheus/prometheus@3b97a63. Picked the upstream naming for the parameter (`enableCTZeroIngestion` vs `ctZeroIngestionEnabled`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing valid threshold for inserting zero's at StartTimeUnixNano on OTLP Write requests.
The reason why we want to do this is that Grafana's $__rate_interval is typically 4 times the scrape interval so assuming an average DPM of 1 we could have the zero sample 4 minutes before the first sample.
This is a small change that might help with usecases where samples are slightly delayed.
Also we've made this threshold configurable now. It defaults to 5 minutes but it can be overiden for special cases.