[weekly-r304] Cherry pick created timestamp fix #9217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusvazquez
changed the title
jesusvazquez
requested review from
stevesg,
grafanabot and
a team
as code owners
pstibrany
approved these changes
Sep 6, 2024
4 tasks
pstibrany
reviewed
Sep 10, 2024
| @@ -410,7 +410,7 @@ func otelMetricsToTimeseries(ctx context.Context, tenantID string, addSuffixes b | |||
| converter := otlp.NewMimirConverter() | |||
| errs := converter.FromMetrics(ctx, md, otlp.Settings{ | |||
| AddMetricSuffixes: addSuffixes, | |||
| }) | |||
| }, logger) | |||
There was a problem hiding this comment.
Should have been spanLogger. Also on later line.
(Fixed in #9246)
pstibrany
pushed a commit
that referenced
this pull request
Sep 12, 2024
* [weekly-r304] Cherry pick created timestamp fix * Empty commit to trigger CI * Pass logger to FromMetrics * Fix test * Enough attributes for NewAPI
Merged
pstibrany
added a commit
that referenced
this pull request
Sep 13, 2024
* Update mimir-prometheus from weekly-r305. Signed-off-by: Peter Štibraný <[email protected]> * [weekly-r304] Cherry pick created timestamp fix (#9217) * [weekly-r304] Cherry pick created timestamp fix * Empty commit to trigger CI * Pass logger to FromMetrics * Fix test * Enough attributes for NewAPI * OTLP: Convert start timestamps to Mimir created timestamps (#9236) Signed-off-by: Arve Knudsen <[email protected]> Signed-off-by: Jesus Vazquez <[email protected]> Co-authored-by: Arve Knudsen <[email protected]> * Pass spanLogger as logger for OTEL conversion. (#9246) Signed-off-by: Peter Štibraný <[email protected]> --------- Signed-off-by: Peter Štibraný <[email protected]> Signed-off-by: Arve Knudsen <[email protected]> Signed-off-by: Jesus Vazquez <[email protected]> Co-authored-by: Jesus Vazquez <[email protected]> Co-authored-by: Arve Knudsen <[email protected]>
pstibrany
added a commit
that referenced
this pull request
Sep 17, 2024
* Update mimir-prometheus from weekly-r305. Signed-off-by: Peter Štibraný <[email protected]> * [weekly-r304] Cherry pick created timestamp fix (#9217) * [weekly-r304] Cherry pick created timestamp fix * Empty commit to trigger CI * Pass logger to FromMetrics * Fix test * Enough attributes for NewAPI * OTLP: Convert start timestamps to Mimir created timestamps (#9236) Signed-off-by: Arve Knudsen <[email protected]> Signed-off-by: Jesus Vazquez <[email protected]> Co-authored-by: Arve Knudsen <[email protected]> * Pass spanLogger as logger for OTEL conversion. (#9246) Signed-off-by: Peter Štibraný <[email protected]> --------- Signed-off-by: Peter Štibraný <[email protected]> Signed-off-by: Arve Knudsen <[email protected]> Signed-off-by: Jesus Vazquez <[email protected]> Co-authored-by: Jesus Vazquez <[email protected]> Co-authored-by: Arve Knudsen <[email protected]>
Merged
pstibrany
added a commit
that referenced
this pull request
Sep 17, 2024
* Update mimir-prometheus from weekly-r306 branch. Signed-off-by: Peter Štibraný <[email protected]> * Update r305 (#9285) * Update mimir-prometheus from weekly-r305. Signed-off-by: Peter Štibraný <[email protected]> * [weekly-r304] Cherry pick created timestamp fix (#9217) * [weekly-r304] Cherry pick created timestamp fix * Empty commit to trigger CI * Pass logger to FromMetrics * Fix test * Enough attributes for NewAPI * OTLP: Convert start timestamps to Mimir created timestamps (#9236) Signed-off-by: Arve Knudsen <[email protected]> Signed-off-by: Jesus Vazquez <[email protected]> Co-authored-by: Arve Knudsen <[email protected]> * Pass spanLogger as logger for OTEL conversion. (#9246) Signed-off-by: Peter Štibraný <[email protected]> --------- Signed-off-by: Peter Štibraný <[email protected]> Signed-off-by: Arve Knudsen <[email protected]> Signed-off-by: Jesus Vazquez <[email protected]> Co-authored-by: Jesus Vazquez <[email protected]> Co-authored-by: Arve Knudsen <[email protected]> * Update mimir-prometheus, regenerate OTLP conversion code. Signed-off-by: Peter Štibraný <[email protected]> --------- Signed-off-by: Peter Štibraný <[email protected]> Signed-off-by: Arve Knudsen <[email protected]> Signed-off-by: Jesus Vazquez <[email protected]> Co-authored-by: Jesus Vazquez <[email protected]> Co-authored-by: Arve Knudsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR updates weekly-r304 to introduce
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.