Release/2.6.0-RC.0 #1011

henrypalacios · 2022-01-31T21:42:32Z

Release v2.6.0-RC.0

⚠️ DO NOT SQUASH ⚠️

Main features:

Added transactions view
Changes on header and footer (network aware)
Misc bug fixes and improvements

Changelog

Features

cd395a6 header links (#953)
e706409 transaction view (#882)
b082c02 Tx table storybook (#897)
9678a7b Update XDAI, WXDAI and GNO token logos (#986)
57b33bd Adding queue_rules (#955)
d97517e Merge remote-tracking branch 'origin/master' into develop
b734984 Search tx every network (#933)
2f911be Make contracts urls on footer network aware by receiving networkId changes (#934)
6f227a8 Search for tx on search bar (#899)
51885ad Merge pull request #926 from gnosis/release/2.5.0_update_develop
7f14778 Merge branch 'develop' into release/2.5.0_update_develop
fb1d7f2 917 rename xdai to gc (#918)
ee60fd4 Wire up TransactionDetails page with Tx API (#908)
6795db3 Adding getTxOrders to connect Tx API (#900)

Dependency Updates

a43a745 Bump follow-redirects from 1.14.5 to 1.14.7 (#987)
c9cef1f Bump playwright from 1.16.3 to 1.17.2 (#939)
8411ebd Bump @types/styled-components from 5.1.15 to 5.1.19 (#928)
6f463ed Bump @types/node from 14.17.34 to 14.18.1 (#916)

# Summary Closes #855 Implement function to call `/api/v1/transactions/{txHash}/orders` ### Background - Endpoint transaction Orders https://protocol-rinkeby.dev.gnosisdev.com/api/#/default/get_api_v1_transactions__txHash__orders

# Summary Closes #853 **Proposal:** - Reuse functionally from `useGetOrders` and create [`useGetTxOrders`](https://github.com/gnosis/gp-ui/blob/853-wireup-front-and-txapi/src/hooks/useGetOrders.tsx#L79) # To Test - New Hook for `useGetTxOrders` Go to `tx/<TxHash>` like as [/tx/0xc2eb04b549d68c770062591e2561c5b1534ea665c6179d33a779c52376c9161d](https://pr908--gpui.review.gnosisdev.com//tx/0xc2eb04b549d68c770062591e2561c5b1534ea665c6179d33a779c52376c9161d)

# Summary Closes #917 - [x] Replace **XDAI** to **GNOSIS CHAIN** on Header Logo - [x] Substitute `/xdai/...` to `/gc/...` on URL - [x] Replace **xDai** name from `UserDetailsTable` when no orders and found on other networks ## To Test 1. Header Logo Go to https://pr918--gpui.review.gnosisdev.com/gc and verify Header 2. Substitute `xdai` for `gc` Try to use `xdai` URL with https://pr918--gpui.review.gnosisdev.com/xdai 3. Replace **xDai** from `UserDetailsTable` Go to UserDetails with address on `mainnet` [0xFF714b8b0e2700303eC912BD40496C3997ceEa2b](https://pr918--gpui.review.gnosisdev.com/address/0xFF714b8b0e2700303eC912BD40496C3997ceEa2b)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.17.34 to 14.18.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@types/node&package-manager=npm_and_yarn&previous-version=14.17.34&new-version=14.18.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

Update develop branch with release/v2.5.0

Bumps [@types/styled-components](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/styled-components) from 5.1.15 to 5.1.19. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/styled-components">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@types/styled-components&package-manager=npm_and_yarn&previous-version=5.1.15&new-version=5.1.19)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

# Summary Closes #913 ![image](https://user-images.githubusercontent.com/622217/148095402-fac9408c-1568-4a72-b0ba-fb97257135ee.png) ## To Test Go to [home](https://pr929--gpui.review.gnosisdev.com/)

* Change PROD, BARN explorer URLs * Change PROD, STAGING backend_explorer URLs * Fix typo barn on url * Revert barn URLs API and allow old domain * Keep suffix api in the URL webpack.config.js Co-authored-by: Leandro Boscariol <[email protected]> Co-authored-by: Leandro Boscariol <[email protected]>

…anges (#934)

* remove animation-mobile * remove all animations

* working _getTxOrders * Redirect to another network if tx found * Avoid redirecting before searching on another network * Extract to file tryGetOrderOnAllNetwork functionality

Bumps [playwright](https://github.com/Microsoft/playwright) from 1.16.3 to 1.17.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Microsoft/playwright/releases">playwright's releases</a>.</em></p> <blockquote> <h2>v1.17.2</h2> <h2>Bugfixes</h2> <p><a href="https://github-redirect.dependabot.com/Microsoft/playwright/issues/11274">#11274</a> - fix: pin colors to 1.4.0 <a href="https://github-redirect.dependabot.com/Microsoft/playwright/issues/11228">#11228</a> - fix(click): don't fail on stale context while click</p> <h2>v1.17.1</h2> <h2>Highlights</h2> <p>This patch includes bug fixes for the following issues:</p> <p><a href="https://github-redirect.dependabot.com/microsoft/playwright/issues/10638">microsoft/playwright#10638</a> - [BUG] Locator.click -> subtree intercepts pointer events since version 1.17.0 <a href="https://github-redirect.dependabot.com/microsoft/playwright/issues/10632">microsoft/playwright#10632</a> - [BUG] Playwright 1.17.0 -> After clicking the element - I get an error that click action was failed <a href="https://github-redirect.dependabot.com/microsoft/playwright/issues/10627">microsoft/playwright#10627</a> - [REGRESSION]: Can no longer click Material UI select box <a href="https://github-redirect.dependabot.com/microsoft/playwright/issues/10620">microsoft/playwright#10620</a> - [BUG] trailing zero width whitespace fails toHaveText</p> <h2>Browser Versions</h2> <ul> <li>Chromium 98.0.4695.0</li> <li>Mozilla Firefox 94.0.1</li> <li>WebKit 15.4</li> </ul> <p>This version of Playwright was also tested against the following stable channels:</p> <ul> <li>Google Chrome 96</li> <li>Microsoft Edge 96</li> </ul> <hr /> <p>(1.17.1)</p> <h2>v1.17.0</h2> <h1>Playwright v1.17</h1> <h2>Frame Locators</h2> <p>Playwright 1.17 introduces [frame locators] - a locator to the iframe on the page. Frame locators capture the logic sufficient to retrieve the <code>iframe</code> and then locate elements in that iframe. Frame locators are strict by default, will wait for <code>iframe</code> to appear and can be used in Web-First assertions.</p> <p><img src="https://user-images.githubusercontent.com/746130/142082759-2170db38-370d-43ec-8d41-5f9941f57d83.png" alt="Graphics" /></p> <p>Frame locators can be created with either [<code>page.frameLocator(selector)</code>] or [<code>locator.frameLocator(selector)</code>] method.</p> <pre lang="js"><code>const locator = page.frameLocator('#my-iframe').locator('text=Submit'); await locator.click(); </code></pre> <p>Read more at <a href="https://playwright.dev/docs/next/api/class-framelocator">our documentation</a>.</p> <h2>Trace Viewer Update</h2> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/playwright/commit/b6eb917c29b743e8d63004ae7a24974404461198"><code>b6eb917</code></a> chore: mark 1.17.2 (<a href="https://github-redirect.dependabot.com/Microsoft/playwright/issues/11276">#11276</a>)</li> <li><a href="https://github.com/microsoft/playwright/commit/224bfeba75d5eae5afbd1803f3e3c994b44fdaaa"><code>224bfeb</code></a> cherry-pick(release-1.17): chore: fix test-package-installation tests on Node...</li> <li><a href="https://github.com/microsoft/playwright/commit/b00e931d4a4d49af740661a724080c751cfeb3ec"><code>b00e931</code></a> cherry-pick(<a href="https://github-redirect.dependabot.com/Microsoft/playwright/issues/11274">#11274</a>): fix: pin <code>colors</code> to <code>1.4.0</code></li> <li><a href="https://github.com/microsoft/playwright/commit/4dfdca1b990604ec2a76f86d3111a3c0e00b95e6"><code>4dfdca1</code></a> cherry-pick(<a href="https://github-redirect.dependabot.com/Microsoft/playwright/issues/11228">#11228</a>): fix(click): don't fail on stale context while cl… (<a href="https://github-redirect.dependabot.com/Microsoft/playwright/issues/11231">#11231</a>)</li> <li><a href="https://github.com/microsoft/playwright/commit/112fe3ae0d5395d807a60a1434d85f24d36cba09"><code>112fe3a</code></a> cherry-pick(<a href="https://github-redirect.dependabot.com/Microsoft/playwright/issues/10771">#10771</a>): devops: setup Docker Qemu for arm64 docker builds</li> <li><a href="https://github.com/microsoft/playwright/commit/5e5a646e16b2326024258adf2a7310e6a533e6a2"><code>5e5a646</code></a> cherry-pick(<a href="https://github-redirect.dependabot.com/Microsoft/playwright/issues/10768">#10768</a>): devops: move docker publishing logic to main repo</li> <li><a href="https://github.com/microsoft/playwright/commit/8e29c814df503ca45048daec47ba7f3504a2afc8"><code>8e29c81</code></a> cherry-pick(<a href="https://github-redirect.dependabot.com/Microsoft/playwright/issues/10685">#10685</a>): fix(focus): make sure strictness is respected</li> <li><a href="https://github.com/microsoft/playwright/commit/9fe65beb93100744b5808b5d84cdf75fe980de56"><code>9fe65be</code></a> cherry-pick+fix(<a href="https://github-redirect.dependabot.com/Microsoft/playwright/issues/10678">#10678</a>): test: add reporter test with grep (<a href="https://github-redirect.dependabot.com/Microsoft/playwright/issues/10682">#10682</a>)</li> <li><a href="https://github.com/microsoft/playwright/commit/ab511165f3cb43bed306cfff662a8bcfdeb2ae2a"><code>ab51116</code></a> cherry-pick(<a href="https://github-redirect.dependabot.com/Microsoft/playwright/issues/10679">#10679</a>): fix(chromium): disable AutoExpandDetailsElement as it br...</li> <li><a href="https://github.com/microsoft/playwright/commit/f802c27d0983ed40a0d678a61897e85c872bd076"><code>f802c27</code></a> cherry-pick(<a href="https://github-redirect.dependabot.com/Microsoft/playwright/issues/10661">#10661</a>): chore: add validations into check_deps</li> <li>Additional commits viewable in <a href="https://github.com/Microsoft/playwright/compare/v1.16.3...v1.17.2">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=playwright&package-manager=npm_and_yarn&previous-version=1.16.3&new-version=1.17.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

# Summary Closes #942 After: ![image](https://user-images.githubusercontent.com/622217/149382484-7e169d21-92da-4656-a70c-184acdd88111.png) Before: ![image](https://user-images.githubusercontent.com/622217/149382540-51fe4567-84e3-4239-a4ac-3664db8e0dfc.png) # To Test Compare the token logos and Gnosis Chain color on: ✅ https://pr986--gpui.review.gnosisdev.com/gc/address/0xff714b8b0e2700303ec912bd40496c3997ceea2b ❌ https://protocol-explorer.dev.gnosisdev.com/gc/address/0xff714b8b0e2700303ec912bd40496c3997ceea2b # Extra Additionally out of 942 issue, I've added two minor CSS fixes: - Invert arrow on network selector. - Add more space between CoW Protocol Logo and the Network list. Before / After ![image](https://user-images.githubusercontent.com/622217/149387599-ce767562-192b-4863-b335-e8728f45af75.png)![image](https://user-images.githubusercontent.com/622217/149388091-bff451d1-da59-4bba-bf70-a05915adf79b.png) GNO token logo added: ![image](https://user-images.githubusercontent.com/622217/149524691-cb24941e-5465-4a44-974c-598d1f860567.png)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.5 to 1.14.7. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/2ede36d7c60d3acdcd324dcd99a9dbd52e4fb3a6"><code>2ede36d</code></a> Release version 1.14.7 of the npm package.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/8b347cbcef7c7b72a6e9be20f5710c17d6163c22"><code>8b347cb</code></a> Drop Cookie header across domains.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/6f5029ae1a0fdab4dc25f6379a5ee303c2319070"><code>6f5029a</code></a> Release version 1.14.6 of the npm package.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/af706bee57de954414c0bde0a9f33e62beea3e52"><code>af706be</code></a> Ignore null headers.</li> <li>See full diff in <a href="https://github.com/follow-redirects/follow-redirects/compare/v1.14.5...v1.14.7">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=follow-redirects&package-manager=npm_and_yarn&previous-version=1.14.5&new-version=1.14.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/gnosis/gp-ui/network/alerts). </details>

* storybook upd * storybook tx table * table data upds for filled table * mob view * story data upds * story data upds * story data upds * story data upds * add invert limprice to mob * invert price for mob and desktop * build fail fix in packs * pack issue fix * packs issue fix * packs issue fix * packs issu fix * packs issu fix * clock icon cloder to the lbl * fix mob tooltip content * tx table upds * upds && ixon upds * link url upd Co-authored-by: Henry Palacios <[email protected]>

# Summary Closes #851, #852 # To Test 1. make search that returns successful result. ex: ![image](https://user-images.githubusercontent.com/25584298/145438455-60533503-beba-4c06-bb9b-c0ea98ba984f.png) 2. follow the link under Order id to get order details ![image](https://user-images.githubusercontent.com/25584298/145438786-0e779f70-72bf-405a-a670-242211ee8ac2.png) 3. follow the link under Transaction Hash to see the TransactionDetails page # Background *Optional: Give background information for changes you've made, that might be difficult to explain via comments*

* header upds * header links upd * header upds * border-radius * hover state Co-authored-by: Ramiro Vazquez <[email protected]>

github-actions · 2022-01-31T21:47:30Z

🔭 Explorer: Explorer test app
🔒 Safe Swap App: Trade test app (add to your safe apps)
📈 Trade: Trade test app
📚 Storybook: Component stories

alfetopito

Looking great, Henry.

One small thing:

In the tx details we are looking at a list of orders instead of transactions

That's all, otherwise looks good to me.

Would also like to have @elena-zh to validate it as well

anxolin

This is a great version! Congrats.

I would only suggest to change the colors of Gnosis Chain:

Current one has no contrast:

My proposal:

    background: rgba(7,121,91,1.00);
    color: white;
}

cc/ @biocom

anxolin · 2022-02-01T09:20:59Z

src/components/transaction/TransactionTable/index.tsx

+        <>
+          {items.map((item, i) => (
+            <RowTransaction
+              key={`${item.shortId}-${i}`}


Curious why the ${i} was needed here. Can't we just identify the order by its ID alone? Wouldn't this be better?

elena-zh · 2022-02-01T10:34:06Z

Looking great, Henry.

One small thing:

In the tx details we are looking at a list of orders instead of transactions

That's all, otherwise looks good to me.

Would also like to have @elena-zh to validate it as well

I created a separate issue for this #1014

anxolin · 2022-02-01T10:36:10Z

Why do we open orders in a new tab? I think it should just navigate

elena-zh · 2022-02-01T10:36:13Z

This is a great version! Congrats.

I would only suggest to change the colors of Gnosis Chain:

Current one has no contrast:

My proposal:
    background: rgba(7,121,91,1.00);
    color: white;
}
cc/ @biocom

I have created #1015 task for this

elena-zh · 2022-02-01T10:43:23Z

Why do we open orders in a new tab? I think it should just navigate

@anxolin , I think, we used the same logic as we do for the User details page: orders are opened in a new tab from there.
See the video: https://watch.screencastify.com/v/5DPR1ZKKwCSTcCCqTIKG

I think, we should follow the same logic everywhere. So if we want to open orders in the same tab from each place in the app, I will create an enhancement for this.

Thanks

elena-zh · 2022-02-01T10:57:37Z

Hey @henrypalacios , I faced at least 2 times the issue when TX data can't be loaded due to errors in the console.
Could you please take a look at it?

elena-zh

I'd like to request changes due to this issue: #1017
Besides, it would be nice to take a look issues mentioned and reported above (#1016, #1014)

Issue #1018 is not exactly related to the current PR, but it would be nice to fix before the release.

anxolin · 2022-02-01T11:19:06Z

I'd love to add another request. Could we also add a link to Analytics in the header with https://dune.xyz/gnosis.protocol/Gnosis-Protocol-V2 . It could go after community

anxolin · 2022-02-01T11:30:43Z

@anxolin , I think, we used the same logic as we do for the User details page: orders are opened in a new tab from there.
See the video: https://watch.screencastify.com/v/5DPR1ZKKwCSTcCCqTIKG

I think, we should follow the same logic everywhere. So if we want to open orders in the same tab from each place in the app, I will create an enhancement for this.

Thanks for bringing this up. I think we should open all those links in the same tab, just a normal navigation. Reason: it happens within the same app, and an user can always right click and open in a new tab if they want

elena-zh · 2022-02-01T11:37:47Z

I'd love to add another request. Could we also add a link to Analytics in the header with https://dune.xyz/gnosis.protocol/Gnosis-Protocol-V2 . It could go after community

Added a task #1019

elena-zh · 2022-02-01T11:42:20Z

@anxolin , I think, we used the same logic as we do for the User details page: orders are opened in a new tab from there.
See the video: https://watch.screencastify.com/v/5DPR1ZKKwCSTcCCqTIKG
I think, we should follow the same logic everywhere. So if we want to open orders in the same tab from each place in the app, I will create an enhancement for this.

Thanks for bringing this up. I think we should open all those links in the same tab, just a normal navigation. Reason: it happens within the same app, and an user can always right click and open in a new tab if they want

Created #1020 issue for this.

anxolin · 2022-02-01T11:59:24Z

One other small suggestion. Not for this release, but probably nice for other ones.

I really like how now, in the details you click in the TX or ADDRESS and takes you to the relevant page in the explorer
In both cases, we used to send the user to Etherscan, wich is appreciated by them, since its something very familiar
Now we still go to etherscan, by clicking on the address in the top of both pages
HOWEVER: it's not clear enough that this will be the case. I feel the tx could have a label saying (View in Etherscan) to be more explicit. Otherwise you never know which links take you out of the explorer

@biocom @alfetopito @elena-zh WDYT?

elena-zh · 2022-02-01T12:09:19Z

@anxolin , great idea!
'View on Etherscan/Blockscount' will definitely explain a user where he/she is going to be navigated when pressing on the link address/TxHash at the top of the page.

But then, we will need to add the message 'View on Etherscan/Blockscount' near the link everywhere in the app for consistency

WDYT?

anxolin · 2022-02-01T12:37:44Z

But then, we will need to add the message 'View on Etherscan/Blockscount' near the link everywhere in the app for consistency

Good point! although i think for tokens is too much, at least for now :)
Maybe if in the future the token doesn't take you to Etherscan we can follow the same logic. I could see a page for the token, showing some stats on top (total traded volume, 24h traded volume), also latest trades. So if we had this, we would be coherent just by adding a link in the top taking you to etherscan.

For now, we can make an exception for tokens imo

elena-zh · 2022-02-01T13:43:33Z

@anxolin , I have created an enhancement for this #1021

anxolin · 2022-02-01T13:51:42Z

I will merge this, so we can have a staging URL with this version. I think its nice, because allow us to visualize transactions of settlements in production (the PR link works with development only).

I think the relevant improvements suggested in this PR can be done as independent PRs against release/2.6.0

elena-zh · 2022-02-01T13:55:22Z

I will merge this, so we can have a staging URL with this version. I think its nice, because allow us to visualize transactions of settlements in production (the PR link works with development only).

I think the relevant improvements suggested in this PR can be done as independent PRs against release/2.6.0

@anxolin , we have related critical issue unfixed #1017 .
And from my perspective it is important to fix it before merging to master..

Also, it would be great to fix issues I encountered during my regression run.

alfetopito · 2022-02-01T17:56:04Z

What about adding the Etherscan icon like we do on CowSwap

But not to every single link, just where it's not obvious.
I wouldn't for example add it to token links

henrypalacios and others added 23 commits December 20, 2021 15:26

Adding getTxOrders to connect Tx API (#900)

6795db3

# Summary Closes #855 Implement function to call `/api/v1/transactions/{txHash}/orders` ### Background - Endpoint transaction Orders https://protocol-rinkeby.dev.gnosisdev.com/api/#/default/get_api_v1_transactions__txHash__orders

Merge branch 'develop' into release/2.5.0_update_develop

7f14778

Merge pull request #926 from gnosis/release/2.5.0_update_develop

51885ad

Update develop branch with release/v2.5.0

Search for tx on search bar (#899)

6f227a8

Rebranding: CoW Protocol Explorer (#929)

6b8733c

# Summary Closes #913 ![image](https://user-images.githubusercontent.com/622217/148095402-fac9408c-1568-4a72-b0ba-fb97257135ee.png) ## To Test Go to [home](https://pr929--gpui.review.gnosisdev.com/)

Update URLs barn staging (#945)

629b534

Make contracts urls on footer network aware by receiving networkId ch…

2f911be

…anges (#934)

Fix Logo animation (#946)

f6b186f

* remove animation-mobile * remove all animations

Search tx every network (#933)

b734984

* working _getTxOrders * Redirect to another network if tx found * Avoid redirecting before searching on another network * Extract to file tryGetOrderOnAllNetwork functionality

Merge remote-tracking branch 'origin/master' into develop

d97517e

Adding queue_rules (#955)

57b33bd

header links (#953)

cd395a6

* header upds * header links upd * header upds * border-radius * hover state Co-authored-by: Ramiro Vazquez <[email protected]>

Bump Version to 2.6.0-rc.1

a1d05f3

henrypalacios added app:Explorer Explorer App Protofire task to the protofire team labels Jan 31, 2022

henrypalacios self-assigned this Jan 31, 2022

henrypalacios changed the title ~~Release/2.6.0-RC-0~~ Release/2.6.0-RC.1 Jan 31, 2022

henrypalacios requested review from alfetopito and anxolin January 31, 2022 21:54

alfetopito approved these changes Feb 1, 2022

View reviewed changes

anxolin approved these changes Feb 1, 2022

View reviewed changes

elena-zh mentioned this pull request Feb 1, 2022

Change 'Transactions' to 'Orders' in the transaction table #1014

Closed

elena-zh mentioned this pull request Feb 1, 2022

Change the colors of Gnosis Chain: increase contrast #1015

Closed

elena-zh mentioned this pull request Feb 1, 2022

Menu button is clued to the network switcher in a mobile view #1016

Closed

elena-zh suggested changes Feb 1, 2022

View reviewed changes

elena-zh mentioned this pull request Feb 1, 2022

Cannot load data for explorer pages in iOS devices #1017

Closed

elena-zh mentioned this pull request Feb 1, 2022

Add a link to Analytics in the header #1019

Closed

elena-zh mentioned this pull request Feb 1, 2022

Make internal links opened in the same tab, external links in another tab #1020

Closed

elena-zh mentioned this pull request Feb 1, 2022

Add 'View on Etherscan/Blockscount' to external links #1021

Closed

anxolin merged commit b18eb3c into master Feb 1, 2022

henrypalacios deleted the release/2.6.0 branch February 2, 2022 12:38

henrypalacios changed the title ~~Release/2.6.0-RC.1~~ Release/2.6.0-RC.0 Feb 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release/2.6.0-RC.0 #1011

Release/2.6.0-RC.0 #1011

henrypalacios commented Jan 31, 2022 •

edited

Loading

github-actions bot commented Jan 31, 2022

alfetopito left a comment

anxolin left a comment

anxolin Feb 1, 2022

elena-zh commented Feb 1, 2022

anxolin commented Feb 1, 2022

elena-zh commented Feb 1, 2022

elena-zh commented Feb 1, 2022 •

edited

Loading

elena-zh commented Feb 1, 2022

elena-zh left a comment •

edited

Loading

anxolin commented Feb 1, 2022 •

edited

Loading

anxolin commented Feb 1, 2022 •

edited

Loading

elena-zh commented Feb 1, 2022

elena-zh commented Feb 1, 2022

anxolin commented Feb 1, 2022

elena-zh commented Feb 1, 2022

anxolin commented Feb 1, 2022

elena-zh commented Feb 1, 2022

anxolin commented Feb 1, 2022

elena-zh commented Feb 1, 2022 •

edited

Loading

alfetopito commented Feb 1, 2022

Release/2.6.0-RC.0 #1011

Release/2.6.0-RC.0 #1011

Conversation

henrypalacios commented Jan 31, 2022 • edited Loading

Release v2.6.0-RC.0

Main features:

Changelog

Features

Dependency Updates

github-actions bot commented Jan 31, 2022

alfetopito left a comment

Choose a reason for hiding this comment

anxolin left a comment

Choose a reason for hiding this comment

anxolin Feb 1, 2022

Choose a reason for hiding this comment

elena-zh commented Feb 1, 2022

anxolin commented Feb 1, 2022

elena-zh commented Feb 1, 2022

elena-zh commented Feb 1, 2022 • edited Loading

elena-zh commented Feb 1, 2022

elena-zh left a comment • edited Loading

Choose a reason for hiding this comment

anxolin commented Feb 1, 2022 • edited Loading

anxolin commented Feb 1, 2022 • edited Loading

elena-zh commented Feb 1, 2022

elena-zh commented Feb 1, 2022

anxolin commented Feb 1, 2022

elena-zh commented Feb 1, 2022

anxolin commented Feb 1, 2022

elena-zh commented Feb 1, 2022

anxolin commented Feb 1, 2022

elena-zh commented Feb 1, 2022 • edited Loading

alfetopito commented Feb 1, 2022

henrypalacios commented Jan 31, 2022 •

edited

Loading

elena-zh commented Feb 1, 2022 •

edited

Loading

elena-zh left a comment •

edited

Loading

anxolin commented Feb 1, 2022 •

edited

Loading

anxolin commented Feb 1, 2022 •

edited

Loading

elena-zh commented Feb 1, 2022 •

edited

Loading