Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

917 rename xdai to gc #918

Merged
merged 3 commits into from
Dec 21, 2021
Merged

917 rename xdai to gc #918

merged 3 commits into from
Dec 21, 2021

Conversation

henrypalacios
Copy link
Contributor

@henrypalacios henrypalacios commented Dec 20, 2021 •
edited
Loading

Summary

Closes #917

  • Replace XDAI to GNOSIS CHAIN on Header Logo
  • Substitute /xdai/... to /gc/... on URL
  • Replace xDai name from UserDetailsTable when no orders and found on other networks

To Test

  1. Header Logo
    Go to https://pr918--gpui.review.gnosisdev.com/gc and verify Header
  2. Substitute xdai for gc
    Try to use xdai URL with https://pr918--gpui.review.gnosisdev.com/xdai
  3. Replace xDai from UserDetailsTable
    Go to UserDetails with address on mainnet 0xFF714b8b0e2700303eC912BD40496C3997ceEa2b

@henrypalacios henrypalacios self-assigned this Dec 20, 2021
@henrypalacios henrypalacios added app:Explorer Explorer App Protofire task to the protofire team labels Dec 20, 2021
@github-actions
Copy link

@elena-zh
Copy link

Hey @henrypalacios , could you please include network switcher feature (PR#898) into this PR, as it is currently merged to DEV, and it would be nice to have it here.

@elena-zh
Copy link

Hey @alfetopito , what are we going to do with token names?
image

Should we rename them according to description in the Blockscount?
image

@elena-zh
Copy link

All the rest changes LGTM.

alfetopito
alfetopito reviewed Dec 21, 2021
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeating what I said over slack, base this on develop as it will be nicer to have it with the network switcher

@alfetopito
Copy link
Contributor

Hey @alfetopito , what are we going to do with token names? image

Should we rename them according to description in the Blockscount? image

Well, that's the token name in the contract as it was deployed.
We could dynamically replace it but I don't think we should just yet.
Don't know whether Blockscout does this dynamically or have a hard coded mapping on their side.

Anyway, out of the scope and super low priority, I wouldn't do this any time soon.

@elena-zh elena-zh mentioned this pull request Dec 21, 2021
Open
@elena-zh
Copy link

Thanks, @alfetopito , I have created a super low priority issue for changing token names #919

@alongoni alongoni linked an issue Dec 21, 2021 that may be closed by this pull request
Rename xDai to Gnosis Chain #917
Closed
@henrypalacios henrypalacios changed the base branch from release/2.4.0 to develop December 21, 2021 14:43
@henrypalacios
Copy link
Contributor Author

I have updated this PR with the changes in develop branch.
Could you please look at it again @elena-zh, @alfetopito?

elena-zh
elena-zh approved these changes Dec 21, 2021
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

alongoni
alongoni suggested changes Dec 21, 2021
View reviewed changes
src/components/NetworkSelector/NetworkSelector.styled.ts Outdated
@@ -67,7 +67,7 @@ export const Option = styled.div`
&.rinkeby {
background: ${({ theme }): string => theme.yellow4};
}
&.xdai {
&.gnosischain {
background: ${({ theme }): string => theme.orange1};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to change the Gnosis Chain color to #48a9a6
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And for the selector:

    background: rgb(72 169 166 / 25%);
    color: #48a9a

image

Copy link
Contributor Author

@henrypalacios henrypalacios Dec 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I have applied it too see how it looks?

It would make more sense with the brand. WDYT @alfetopito?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@alongoni alongoni self-requested a review December 21, 2021 23:13
alongoni
alongoni approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@alongoni alongoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

alfetopito
alfetopito approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job Henry! Looks great!

src/styles/colours.ts
@@ -3,6 +3,7 @@ export const COLOURS = {
whiteDark: '#e9e9f0',
blue: '#3F77FF',
blueDark: '#185afb',
hippieBlue: '#48A9A6',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol what?

@alfetopito alfetopito added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Dec 21, 2021
@mergify mergify bot merged commit fb1d7f2 into develop Dec 21, 2021
henrypalacios added a commit that referenced this pull request Dec 22, 2021
@henrypalacios
917 rename xdai to gc (#918)
440788c 
# Summary

Closes #917

- [x] Replace **XDAI** to **GNOSIS CHAIN** on Header Logo
- [x] Substitute `/xdai/...` to `/gc/...` on URL
- [x] Replace **xDai** name from `UserDetailsTable` when no orders and found on other networks

## To Test

1. Header Logo
  Go to https://pr918--gpui.review.gnosisdev.com/gc and verify Header
2. Substitute `xdai` for `gc`
  Try to use `xdai` URL with https://pr918--gpui.review.gnosisdev.com/xdai
3. Replace **xDai** from `UserDetailsTable`
  Go to UserDetails with address on `mainnet` [0xFF714b8b0e2700303eC912BD40496C3997ceEa2b](https://pr918--gpui.review.gnosisdev.com/address/0xFF714b8b0e2700303eC912BD40496C3997ceEa2b)

(cherry picked from commit fb1d7f2)
@henrypalacios henrypalacios mentioned this pull request Dec 22, 2021
Merged
@alfetopito alfetopito deleted the 917-rename-xdai-to-gc branch December 23, 2021 10:30
This was referenced Jan 31, 2022
Merged
Merged
@anxolin anxolin mentioned this pull request Jan 26, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@alongoni alongoni alongoni approved these changes

@elena-zh elena-zh elena-zh approved these changes

@anxolin anxolin Awaiting requested review from anxolin

@matextrem matextrem Awaiting requested review from matextrem

Assignees

@henrypalacios henrypalacios

Labels
app:Explorer Explorer App Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds Protofire task to the protofire team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename xDai to Gnosis Chain
4 participants
@henrypalacios @elena-zh @alfetopito @alongoni