Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

Update logos for Gnosis chain according to the media-kit #942

Closed
elena-zh opened this issue Jan 10, 2022 · 3 comments · Fixed by #986
Closed

Update logos for Gnosis chain according to the media-kit #942

elena-zh opened this issue Jan 10, 2022 · 3 comments · Fixed by #986
Assignees
@alongoni
Labels
app:Explorer Explorer App Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt Protofire task to the protofire team

Comments

@elena-zh
Copy link

gnosis/cowswap#2023 (comment)

Additionally to the written name changes, can we also update the corresponding logos to this ones: https://www.xdaichain.com/media/media-kit
@elena-zh elena-zh added app:Explorer Explorer App Protofire task to the protofire team Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt labels Jan 10, 2022
@elena-zh elena-zh mentioned this issue Jan 10, 2022
Merged
@alongoni alongoni self-assigned this Jan 10, 2022
@elena-zh
Copy link
Author

@alongoni , @alfetopito
I have just noticed that we do not have logos in Explorer app.
May be we need to add them?
For now, as far as I understand, we need to update the chain colors. Correct?
image

@alfetopito
Copy link
Contributor

That's part of the design choice to not include it, so I would keep it as is.
The only thing to be done here would be the color.

@elena-zh
Copy link
Author

Since under this task we should update Gnosis chain colors only, I would increase its scope and would suggest to change xDAI and wxDAI tokens' symbols like we have already implemented in gnosis/cowswap#2122

@alongoni alongoni mentioned this issue Jan 13, 2022
Merged
@mergify mergify bot closed this as completed in #986 Jan 14, 2022
mergify bot pushed a commit that referenced this issue Jan 14, 2022
@alongoni
Update XDAI, WXDAI and GNO token logos (#986)
9678a7b 
# Summary

Closes #942
After:
![image](https://user-images.githubusercontent.com/622217/149382484-7e169d21-92da-4656-a70c-184acdd88111.png)
Before: 
![image](https://user-images.githubusercontent.com/622217/149382540-51fe4567-84e3-4239-a4ac-3664db8e0dfc.png)
 

# To Test
Compare the token logos and Gnosis Chain color on: 
✅ https://pr986--gpui.review.gnosisdev.com/gc/address/0xff714b8b0e2700303ec912bd40496c3997ceea2b
❌ https://protocol-explorer.dev.gnosisdev.com/gc/address/0xff714b8b0e2700303ec912bd40496c3997ceea2b

# Extra
Additionally out of 942 issue, I've added two minor CSS fixes:
- Invert arrow on network selector.
- Add more space between CoW Protocol Logo and the Network list.
Before    /    After
![image](https://user-images.githubusercontent.com/622217/149387599-ce767562-192b-4863-b335-e8728f45af75.png)![image](https://user-images.githubusercontent.com/622217/149388091-bff451d1-da59-4bba-bf70-a05915adf79b.png)

GNO token logo added:
![image](https://user-images.githubusercontent.com/622217/149524691-cb24941e-5465-4a44-974c-598d1f860567.png)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alongoni alongoni

Labels
app:Explorer Explorer App Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt Protofire task to the protofire team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update XDAI, WXDAI and GNO token logos gnosis/gp-ui
3 participants
@alfetopito @alongoni @elena-zh