Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

change network name: xDai -> Gnosis Chain #2023

Merged
merged 6 commits into from
Dec 22, 2021
Merged

change network name: xDai -> Gnosis Chain #2023

merged 6 commits into from
Dec 22, 2021

Conversation

alongoni
Copy link
Contributor

@alongoni alongoni commented Dec 20, 2021 •
edited
Loading

Summary

Fixes #2021
image

To Test

  1. <> Open the network selector: Now you can see and select "Gnosis Chain"

@alongoni alongoni added app:CowSwap CowSwap app Protofire Handled by Protofire development team Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt labels Dec 20, 2021
@alongoni alongoni self-assigned this Dec 20, 2021
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@alfetopito
Copy link
Contributor

Awesome Agustin, thanks for the quick response.

I'd like to ask to keep the same icon as before, since it hasn't changed (maybe it'll but I don't know if that's the case)

Screenshot from 2021-12-20 16-17-42

https://www.xdaichain.com/

@alongoni alongoni marked this pull request as ready for review December 20, 2021 20:04
elena-zh
elena-zh suggested changes Dec 21, 2021
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alongoni , great job!

However, some issues:

  1. XDAI is displayed in the Activity modal
    activity modal
  2. Tokens in the token list show xDAI
    token list
    Seems that this question is related to the same one in Explorer 917 rename xdai to gc gp-ui#918 (comment) , so I'm addressing it to @alfetopito 😊
  3. The same is for token names when import custom tokens
    import token

@alfetopito
Copy link
Contributor

Repeating what I said in the other issue regarding the tokens that contain xDai in their names.
I don't think we should change that yet. Out of the scope of this task.

@alongoni alongoni requested a review from elena-zh December 21, 2021 19:16
elena-zh
elena-zh approved these changes Dec 22, 2021
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@W3stside W3stside changed the base branch from develop to release/1.8.0 December 22, 2021 17:38
@W3stside W3stside changed the base branch from release/1.8.0 to develop December 22, 2021 17:47
@alfetopito alfetopito merged commit 9eab91a into develop Dec 22, 2021
@alfetopito alfetopito deleted the 2021-rename-network-gnosis-chain branch December 22, 2021 17:56
W3stside pushed a commit that referenced this pull request Dec 22, 2021
@alongoni @W3stside
change network name: xDai -> Gnosis Chain (#2023)
f92f3de 
* change network label and add gnosis logo

* change GC selected network

* update gnosis chain logo

* logo update

* update constants

* change gc on activity modal
@elena-zh elena-zh mentioned this pull request Dec 23, 2021
Closed
nenadV91 pushed a commit that referenced this pull request Jan 3, 2022
fix: properly set upper/lower base/quote on manual inversion (#2023)
b1d8831
@avsavsavs
Copy link
Contributor

Hey, additionally to the written name changes, can we also update the corresponding logos to this ones: https://www.xdaichain.com/media/media-kit

At least the chain one, im guessing the token one is dependent on the token lists being update.

@elena-zh elena-zh mentioned this pull request Jan 10, 2022
Closed
@elena-zh
Copy link

elena-zh commented Jan 10, 2022 •
edited
Loading

@avsavsavs , I reported separate issues for this #2065, gnosis/gp-ui#942 as the current task is already merged and closed.

@elena-zh elena-zh mentioned this pull request Jan 10, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@matextrem matextrem matextrem approved these changes

@elena-zh elena-zh elena-zh approved these changes

@henrypalacios henrypalacios Awaiting requested review from henrypalacios

@ramirotw ramirotw Awaiting requested review from ramirotw

Assignees

@alongoni alongoni

Labels
app:CowSwap CowSwap app Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt Protofire Handled by Protofire development team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename xDai to Gnosis Chain
5 participants
@alongoni @alfetopito @avsavsavs @elena-zh @matextrem