Skip to content
This repository was archived by the owner on Apr 4, 2022. It is now read-only.

'Search not found' page is not responsive in a mobile view when search for a long value #1018

Closed
elena-zh opened this issue Feb 1, 2022 · 0 comments · Fixed by #1037
Closed

'Search not found' page is not responsive in a mobile view when search for a long value #1018

elena-zh opened this issue Feb 1, 2022 · 0 comments · Fixed by #1037
Assignees
@alongoni
Labels
app:Explorer Explorer App Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Protofire task to the protofire team

Comments

@elena-zh
Copy link

elena-zh commented Feb 1, 2022 •
edited
Loading

'Search not found' page is not responsive when search for a long value. As an example, when search for an invalid Tx hash/Order ID.
See the image:
image.png

Besides, the app logo has become center-aligned on such screen and is not visible until scroll the page

Expected: the page should be responsive in a mobile view.
App logo should be always visible.
@elena-zh elena-zh added app:Explorer Explorer App Protofire task to the protofire team Low Severity indicator for defects. It won't cause any major break-down of the system Bug Something isn't working labels Feb 1, 2022
@alongoni alongoni mentioned this issue Feb 8, 2022
Merged
@mergify mergify bot closed this as completed in #1037 Feb 9, 2022
mergify bot pushed a commit that referenced this issue Feb 9, 2022
@alongoni
"Search not found" responsive page (#1037)
e7e5b97 
# Summary

Closes #1018 
![image](https://user-images.githubusercontent.com/622217/153061146-fb54e5e4-89c7-40ce-b2a4-500857d59560.png)

# To Test

1. Open the explorer with a [wrong address](https://pr1037--gpui.review.gnosisdev.com/search/0x69904ff6d6100799344E5C9A2806936318F6ba4fWRONG) in a mobile device or use the DevTools.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alongoni alongoni

Labels
app:Explorer Explorer App Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Protofire task to the protofire team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

"Search not found" responsive page gnosis/gp-ui
2 participants
@alongoni @elena-zh