Skip to content
This repository was archived by the owner on Apr 4, 2022. It is now read-only.

"Search not found" responsive page #1037

Merged
merged 5 commits into from
Feb 9, 2022
Merged

"Search not found" responsive page #1037

merged 5 commits into from
Feb 9, 2022

Conversation

alongoni
Copy link
Contributor

@alongoni alongoni commented Feb 8, 2022 •
edited
Loading

Summary

Closes #1018
image

To Test

  1. Open the explorer with a wrong address in a mobile device or use the DevTools.

@alongoni alongoni self-assigned this Feb 8, 2022
@alongoni alongoni added app:Explorer Explorer App Protofire task to the protofire team Mobile Affects mobile only Bug Something isn't working labels Feb 8, 2022
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

@alongoni alongoni marked this pull request as ready for review February 8, 2022 19:39
henrypalacios
henrypalacios reviewed Feb 9, 2022
View reviewed changes
src/apps/explorer/styled.ts Outdated
margin-left: auto;
margin-right: auto;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have sworn that I have already done so in #1026

henrypalacios
henrypalacios approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@henrypalacios henrypalacios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍

@elena-zh
Copy link

elena-zh commented Feb 9, 2022 •
edited
Loading

Hey @alongoni , changes LGTM for a Mobile resolution.
Still it would be nice to make screen's content look better in a tablet resolution with screen width in [740-920] px.
image

Could you please fix it?
https://watch.screencastify.com/v/Y3IDAwOdcnj2G6ZFpGaO

@alongoni
Copy link
Contributor Author

alongoni commented Feb 9, 2022

hey @elena-zh can you test it again? Thanks!

elena-zh
elena-zh approved these changes Feb 9, 2022
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alongoni , thanks! LGTM now.
Btw, seems that #885 issue is also fixed here. I have linked it to the PR.

@alongoni alongoni added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Feb 9, 2022
@mergify mergify bot merged commit e7e5b97 into develop Feb 9, 2022
@alfetopito alfetopito deleted the 1018-search-not-found-page-responsive branch February 9, 2022 18:30
This was referenced Apr 1, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@henrypalacios henrypalacios henrypalacios approved these changes

@elena-zh elena-zh elena-zh approved these changes

@matextrem matextrem Awaiting requested review from matextrem

Assignees

@alongoni alongoni

Labels
app:Explorer Explorer App Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds Bug Something isn't working Mobile Affects mobile only Protofire task to the protofire team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Search not found' page is not responsive in a mobile view when search for a long value
3 participants
@alongoni @elena-zh @henrypalacios