This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Fix race condition when replacing/cancelling on-chain txs #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
ramirotw
pushed a commit
that referenced
this pull request
Feb 18, 2022
#2474) * fix(SafariSquareDots): fixed by using border-top-with instead of border-width * fix(SafariSqaureDots): fixed by using a min width of 5px and then following the width of the screen if the screen is too wide * fix(SafariSquareDots): fixed by using Dot SVG instead of border-style CSS * fix(SafariSquareDots): Fixed code follows suggestions from the Pull Request * regenerate snapshots Co-authored-by: NITIPON CHINGTHONGCHAI <[email protected]> Co-authored-by: Justin Domingue <[email protected]>
This was referenced Feb 21, 2022
This was referenced Feb 23, 2022
alfetopito
approved these changes
Feb 23, 2022
There was a problem hiding this comment.
Code-wise looks ok.
@elena-zh can you check if you can still reproduce the issue here?
|
@alfetopito , I'm still testing. |
elena-zh
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
The issue LGTM besides the mentioned above cases:
- [1.6.0] No 'Cancelling' state for transactions in Gnosis Chain #1954 issue is still reproducible in Gnosis Chain, however, a low priority as it is too difficult to reproduce this issue (transactions are running too fast in GC)
- Race conditions when speed up cancellation/twice speed up a transaction #2492 another edge case when speed/up several times OR speed up a cancellation
Besides, I have verified #2486 issue in this PR, and it is also fixed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #1832
This fixes the case where an on-chain tx (wrap/unwrap/approve) is sent and then the user decides to either Cancel or Speed-up that tx. Two things can happen:
The solution avoids removing the old tx from the transactions state, so the perceived UI change is that now both transactions are going to be visible in the Recent Activities modal, and after one gets mined, the other is removed.