Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Race conditions when cancel a Claim transaction #2486

Closed
elena-zh opened this issue Feb 22, 2022 · 2 comments
Closed

Race conditions when cancel a Claim transaction #2486

elena-zh opened this issue Feb 22, 2022 · 2 comments
Labels
app:CowSwap CowSwap app Bug Something isn't working Claim Issues related to 'Claim' feature Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@elena-zh
Copy link

Sometimes, when cancel a Claim transaction, it appears to be not cancelled, but it is hangs in 'Claiming cancelling' state. Activity log shows 'Cancelling' state.**
image.png
image.png
App navigates to https://rinkeby.etherscan.io/tx/0xa236d43bf8d3b03320c1b921190bb11c53f3f4d10b5814b314457c26323b7e4a
Executed transaction is: https://rinkeby.etherscan.io/tx/0x1fc568b15bf5a21bafead8a06c38e8fb59b8a1b68403c1859172a8814cad380f

Expected: transaction is executed, the app shows success screen.

@elena-zh elena-zh added app:CowSwap CowSwap app Claim Issues related to 'Claim' feature Low Severity indicator for defects. It won't cause any major break-down of the system Bug Something isn't working labels Feb 22, 2022
@alfetopito
Copy link
Contributor

As mentioned on slack: this is almost certain stale "claiming" data. It's only updated after the amount is sent to the wallet, and not cleared once claimed.
Simplest solution might be just clear this value when tx is completed, although it could wipe the value from success screen.

@elena-zh
Copy link
Author

@alfetopito , thanks for explanation, but seems that you are mixing up this issue with #2472 issue.

This issue is related to #1832 bug, and a possible fix #2474 .
So I got a stuck 'Cancelling' transaction in the activity modal when a TX was replaced by another one, and it was not updated in the app.

@elena-zh elena-zh closed this as completed Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Bug Something isn't working Claim Issues related to 'Claim' feature Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Development

No branches or pull requests

2 participants