Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Fix race condition when cancelling/speeding up onchain transactions #1832

Closed
ramirotw opened this issue Nov 12, 2021 · 0 comments · Fixed by #2474
Closed

Fix race condition when cancelling/speeding up onchain transactions #1832

ramirotw opened this issue Nov 12, 2021 · 0 comments · Fixed by #2474
Assignees
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Protofire Handled by Protofire development team

Comments

@ramirotw
Copy link
Contributor

Description
Follow up of #1797 (comment)

Possible fix:

I think the solution is to keep track of all of the hashes until one of them is mined to avoid the race condition.

Currently there's a chance that when submitting either a cancel or speed up transactions the original transaction that is being replaced gets mined before the replacement tx. This causes the app to display that tx as Pending since the old transaction reference got removed.

@ramirotw ramirotw added the Protofire Handled by Protofire development team label Nov 12, 2021
@ramirotw ramirotw self-assigned this Nov 12, 2021
@ramirotw ramirotw added Low Severity indicator for defects. It won't cause any major break-down of the system Bug Something isn't working app:CowSwap CowSwap app labels Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Protofire Handled by Protofire development team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant