fix race condition when replacing/cancelling onchain txs (#2474)

gnosis · Mar 2, 2022 · 9059360 · 9059360
1 parent e88eb5e
commit 9059360
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/src/custom/state/enhancedTransactions/reducer.ts b/src/custom/state/enhancedTransactions/reducer.ts
@@ -39,7 +39,10 @@ export interface EnhancedTransactionDetails {
 
   // Wallet specific
   safeTransaction?: SafeMultisigTransactionResponse // Gnosis Safe transaction info
+
+  // Cancelling/Replacing
   replacementType?: ReplacementType // if the user cancelled or speedup the tx it will be reflected here
+  linkedTransactionHash?: string
 }
 
 export interface EnhancedTransactionState {
@@ -113,22 +116,33 @@ export default createReducer(initialState, (builder) =>
       }
       tx.receipt = receipt
       tx.confirmedTime = now()
+
+      if (tx.linkedTransactionHash) {
+        delete transactions[chainId]?.[tx.linkedTransactionHash]
+      }
     })
 
     .addCase(replaceTransaction, (transactions, { payload: { chainId, oldHash, newHash, type } }) => {
-      if (!transactions[chainId]?.[oldHash]) {
+      const allTxs = transactions[chainId] ?? {}
+      if (!allTxs[oldHash]) {
         console.error('Attempted to replace an unknown transaction.')
         return
       }
-      const allTxs = transactions[chainId] ?? {}
+
+      if (allTxs[newHash]) {
+        return
+      }
+
       allTxs[newHash] = {
         ...allTxs[oldHash],
         hash: newHash,
         transactionHash: newHash,
         addedTime: new Date().getTime(),
         replacementType: type,
+        linkedTransactionHash: oldHash,
       }
-      delete allTxs[oldHash]
+
+      allTxs[oldHash].linkedTransactionHash = newHash
     })
 
     .addCase(updateSafeTransaction, (transactions, { payload: { chainId, safeTransaction, blockNumber } }) => {

diff --git a/src/custom/state/enhancedTransactions/updater/CancelReplaceTxUpdater.tsx b/src/custom/state/enhancedTransactions/updater/CancelReplaceTxUpdater.tsx
@@ -60,7 +60,7 @@ export default function CancelReplaceTxUpdater(): null {
   useEffect(() => {
     if (!chainId || !library) return
 
-    // Watch the mempool for cancelation/replacement of tx
+    // Watch the mempool for cancellation/replacement of tx
     watchTxChanges(pendingHashes, chainId, dispatch)
 
     return () => {