Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Submitting search form (mini) with enter key fires event handlers bound by jquery twice #19

Merged
merged 77 commits into from
Jun 3, 2018

Conversation

gelanivishal
Copy link
Owner

Original Pull Request

magento#15340

Description

When submitting the search form in the header with the enter key on the keyboard, event handlers that were bound to the form submit (through jQuery) are fired twice.

Fixed Issues (if relevant)

  1. Submitting search form (mini) with enter key fires event handlers bound by jquery twice magento/magento2#13793: Submitting search form (mini) with enter key fires event handlers bound by jquery twice

Manual testing scenarios

  1. Create a javascript which adds an event handler to the form submit
  2. $('#search_mini_form').on('submit', function(e) {
    console.log('listening for form submit');
    });
  3. Submit the search form in the header with a value by pressing the enter button

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

ankurseepossible and others added 30 commits February 27, 2018 12:44
…ed proxy c… magento#15177

 - Merge Pull Request magento#15177 from bartek9007/magento2:proxy-for-class-with-variadic-argument-method
 - Merged commits:
   1. 92a6cce
… amount discount

- Made tests more robust
- Clean up after better
… amount discount for whole cart

- Fix incorrect comment
MC-212: Admin should be able to remove images from category

- added mftf tests
…eadcrumbs component magento#15178 magento#15478

 - Merge Pull Request magento#15478 from vovayatsyuk/magento2:2.3-fix-breadcrumbs-without-mageMenu
 - Merged commits:
   1. 7b1d1b6
   2. fd03f7c
…agento#15574

 - Merge Pull Request magento#15574 from osrecio/magento2:2.3-develop-PR-port-15269
 - Merged commits:
   1. 154fc40
…]es magento#15575

 - Merge Pull Request magento#15575 from osrecio/magento2:2.3-develop-PR-port-15275
 - Merged commits:
   1. 6a0f4ca
   2. b4398ae
magento-engcom-team and others added 28 commits June 1, 2018 22:56
 - merged latest code from mainline branch
Accepted Public Pull Requests:
 - magento#15537: [Forwardport] Updated font-size variable and standardize #ToDo UI (by @vgelani)
 - magento#15578: [Forwardport] magento#12820 - Wrong annotation in _toOptionArray - magento/framework/Data/� (by @osrecio)
 - magento#15595: [Forwardport] [fix] dynamical assigned property in webapi (by @mzeis)
 - magento#15575: [Forwardport] [fix] typo in method name _exportAddress[s]es (by @osrecio)
 - magento#15574: [Forwardport] Fix typo in Image::open exception message (by @osrecio)
…o 2.3-develop

# Conflicts:
#	app/code/Magento/Sales/etc/di.xml
…o 2.3-develop

# Conflicts:
#	app/code/Magento/Sales/etc/di.xml
…OptionPrice magento#15576

 - Merge Pull Request magento#15576 from osrecio/magento2:2.3-develop-PR-port-15276
 - Merged commits:
   1. 784099e
   2. 382d685
…nto#15660 magento#15682

 - Merge Pull Request magento#15682 from ankurvr/magento2:ankurvr-patch-2.3-develop
 - Merged commits:
   1. f5f3c76
   2. d696233
   3. 424324e
   4. eca36b2
   5. 98265ab
   6. ac220b7
   7. 12041e1
…to/framework/Data/… magento#15670

 - Merge Pull Request magento#15670 from vgelani/magento2:2.3-develop-PR-port-15336
 - Merged commits:
   1. 11923bc
 - Merge Pull Request magento#15667 from vgelani/magento2:2.3-develop-PR-port-15602
 - Merged commits:
   1. 2feaf30
…agento#15659

 - Merge Pull Request magento#15659 from DanielRuf/magento2:2.3-develop-PR-port-15305
 - Merged commits:
   1. 1113749


 - Merge Pull Request magento#15658 from vgelani/magento2:2.3-develop-PR-port-15398
 - Merged commits:
   1. 891fcdb
 - Merge Pull Request magento#15646 from vgelani/magento2:2.3-develop-PR-port-15549
 - Merged commits:
   1. 1d51097
Accepted Public Pull Requests:
 - magento#15646: [Forwardport] Fixed typo error (by @vgelani)
 - magento#15658: [Forwardport] Fixed set template syntax issue (by @vgelani)
 - magento#15659: [Forwardport] chore: remove extraneous cursor property (by @DanielRuf)
 - magento#15667: [Forwardport] set correct annotation (by @vgelani)
 - magento#15670: [Forwardport] Wrong annotation in _toOptionArray - magento/framework/Data/� (by @vgelani)
 - magento#15682: [Forwardport] Wrong Last orders amount on dashboard magento#15660 (by @ankurvr)
 - magento#15576: [Forwardport] [fix] typo in method name _getCharg[e]ableOptionPrice (by @osrecio)
 - magento#15623: Fix translations (by @cherednichenkoa)
 - magento#15478: [Forwardport] Removed mageMenu widget dependency from breadcrumbs component magento#15178 (by @vovayatsyuk)
 - magento#15177: Adding support for variadic arguments' method in generated proxy c� (by @bartek9007)


Fixed GitHub Issues:
 - magento#15601: Wrong annotation in formatDateTime - lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php (reported by @sanjay-wagento) has been fixed in magento#15667 by @vgelani in 2.3-develop branch
   Related commits:
     1. 2feaf30

 - magento#15601: Wrong annotation in formatDateTime - lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php (reported by @sanjay-wagento) has been fixed in magento#15670 by @vgelani in 2.3-develop branch
   Related commits:
     1. 11923bc

 - magento#15660: Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies (reported by @ankurvr) has been fixed in magento#15682 by @ankurvr in 2.3-develop branch
   Related commits:
     1. f5f3c76
     2. d696233
     3. 424324e
     4. eca36b2
     5. 98265ab
     6. ac220b7
     7. 12041e1

 - magento#14987: Invisible breadcrumbs at product page when mageMenu widget is not used (reported by @vovayatsyuk) has been fixed in magento#15478 by @vovayatsyuk in 2.3-develop branch
   Related commits:
     1. 7b1d1b6
     2. fd03f7c
…ct-join-query

[borg] MAGETWO-45950: Product ResourceCollection wrong Join Query
@gelanivishal gelanivishal merged commit 6e2ce07 into 2.3-develop Jun 3, 2018
gelanivishal pushed a commit that referenced this pull request Aug 10, 2018
[Forwardport] Corrected return message from ProductRuleTest.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.