Removed mageMenu widget dependency from breadcrumbs component #15178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @vovayatsyuk, I took your PR into processing, thank you for collaboration. |
|
Hi @vovayatsyuk. Thank you for your contribution. |
4 tasks
magento-engcom-team
added a commit
that referenced
this pull request
Jun 2, 2018
magento-engcom-team
added a commit
that referenced
this pull request
Jun 2, 2018
Accepted Public Pull Requests: - #15646: [Forwardport] Fixed typo error (by @vgelani) - #15658: [Forwardport] Fixed set template syntax issue (by @vgelani) - #15659: [Forwardport] chore: remove extraneous cursor property (by @DanielRuf) - #15667: [Forwardport] set correct annotation (by @vgelani) - #15670: [Forwardport] Wrong annotation in _toOptionArray - magento/framework/Data/� (by @vgelani) - #15682: [Forwardport] Wrong Last orders amount on dashboard #15660 (by @ankurvr) - #15576: [Forwardport] [fix] typo in method name _getCharg[e]ableOptionPrice (by @osrecio) - #15623: Fix translations (by @cherednichenkoa) - #15478: [Forwardport] Removed mageMenu widget dependency from breadcrumbs component #15178 (by @vovayatsyuk) - #15177: Adding support for variadic arguments' method in generated proxy c� (by @bartek9007) Fixed GitHub Issues: - #15601: Wrong annotation in formatDateTime - lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php (reported by @sanjay-wagento) has been fixed in #15667 by @vgelani in 2.3-develop branch Related commits: 1. 2feaf30 - #15601: Wrong annotation in formatDateTime - lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php (reported by @sanjay-wagento) has been fixed in #15670 by @vgelani in 2.3-develop branch Related commits: 1. 11923bc - #15660: Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies (reported by @ankurvr) has been fixed in #15682 by @ankurvr in 2.3-develop branch Related commits: 1. f5f3c76 2. d696233 3. 424324e 4. eca36b2 5. 98265ab 6. ac220b7 7. 12041e1 - #14987: Invisible breadcrumbs at product page when mageMenu widget is not used (reported by @vovayatsyuk) has been fixed in #15478 by @vovayatsyuk in 2.3-develop branch Related commits: 1. 7b1d1b6 2. fd03f7c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now, breadcrumbs on the product page hardly rely on mageMenu widget. This commit completely removes this dependency to allow to use third-party menus.
Fixed Issues
Manual testing scenarios
app/code/Magento/Theme/view/frontend/templates/html/topmenu.phtmlComments
randomnumber generated by jQueryUI menu. It has nothing to actual category id._initmethod completelyContribution checklist