Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] #12820 - Wrong annotation in _toOptionArray - magento/framework/Data/… #15578

Merged

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented May 29, 2018

Original Pull Request

#15336
Set correct annotation in _toOptionArray - magento/framework/Data/Collection/AbstractDb.php

Description

Set correct annotation in _toOptionArray - magento/framework/Data/Collection/AbstractDb.php

Fixed Issues (if relevant)

  1. magento/magento2#<12820>: Wrong annotation in _toOptionArray - magento/framework/Data/Collection/AbstractDb.php

Manual testing scenarios

  1. Please check request parameter in _toOptionArray - magento/framework/Data/Collection/AbstractDb.php

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone May 30, 2018
@magento-engcom-team magento-engcom-team added Release Line: 2.3 Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner Component: Framework/Data Progress: accept labels May 30, 2018
@magento-engcom-team magento-engcom-team merged commit 6e3acbc into magento:2.3-develop Jun 1, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 1, 2018
@magento-engcom-team
Copy link
Contributor

Hi @osrecio. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Component: Framework/Data Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants