Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fix typo in Image::open exception message #15574

Merged

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented May 29, 2018

Original Pull Request

#15269

Description

Fixes a typo in the \Magento\Framework\Image::open exception message.

Previous message:

File {file} does not exists.

Corrected message:

File {file} does not exist.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

  1. Given that...
  • There exists a page where an image is opened,
  • but the actual image file does not exist,
  • and the exception is not silently caught and ignored,
  1. Expect to receive a properly-spelled exception message.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone May 30, 2018
@magento-engcom-team magento-engcom-team added Release Line: 2.3 Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner Component: Framework/Image labels May 30, 2018
@osrecio
Copy link
Member Author

osrecio commented May 30, 2018

I restarted the jobs in Travis. Seems like other error related with travis and not with PR.

@magento-engcom-team
Copy link
Contributor

Hi @osrecio. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Component: Framework/Image Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants