Deprecate in favor of ember-network? #21
Comments
|
it seems that |
|
Yep, which argues even more for deprecating one of them 😜 |
|
@rwjblue |
|
I believe ember-network was copied from here, with lofty goals of being more then just I would gladly maintain one, but not both... |
|
cc @tomdale whats your plan for ember-network as it at one point was more aspirational but seems to have actually lagged behind. |
|
Ya, I think my main point is the same as @stefanpenner. I just don't think we need two competing solutions that are basically the same (and both created by core team members no less!)... |
|
My recommendation is to keep this one, as it is the original and continues to be maintained... tomdale/ember-network#17 |
|
Agreed. |
ember-fetch is being more actively maintained and is more up-to-date with the fetch spec. See discussion in tomdale/ember-network#17 and ember-cli/ember-fetch#21 The one change I made in the tests is because `headers.getAll` was [removed from the current WHATWG standard](https://www.fxsitecompat.com/en-CA/docs/2016/headers-getall-has-been-removed-in-favour-of-get-now-returning-all-values/), so ember-fetch doesn't implement it. Also be advised that 1.4.0 <= ember-fetch < 1.4.2 actually conflicts with ember-network due to ember-cli/ember-fetch#27, which is how I even noticed my app was including ember-network via ember-simple-network.
ember-fetch is being more actively maintained and is more up-to-date with the fetch spec. See discussion in tomdale/ember-network#17 and ember-cli/ember-fetch#21 The one change I made in the tests is because `headers.getAll` was [removed from the current WHATWG standard](https://www.fxsitecompat.com/en-CA/docs/2016/headers-getall-has-been-removed-in-favour-of-get-now-returning-all-values/), so ember-fetch doesn't implement it. Also be advised that 1.4.0 <= ember-fetch < 1.4.2 actually conflicts with ember-network due to ember-cli/ember-fetch#27, which is how I even noticed my app was including ember-network via ember-simple-network.
ember-fetch is being more actively maintained and is more up-to-date with the fetch spec. See discussion in tomdale/ember-network#17 and ember-cli/ember-fetch#21 The one change I made in the tests is because `headers.getAll` was [removed from the current WHATWG standard](https://www.fxsitecompat.com/en-CA/docs/2016/headers-getall-has-been-removed-in-favour-of-get-now-returning-all-values/), so ember-fetch doesn't implement it. Also be advised that 1.4.0 <= ember-fetch < 1.4.2 actually conflicts with ember-network due to ember-cli/ember-fetch#27, which is how I even noticed my app was including ember-network via ember-simple-network.
ember-fetch is being more actively maintained and is more up-to-date with the fetch spec. See discussion in tomdale/ember-network#17 and ember-cli/ember-fetch#21 The one change I made in the tests is because `headers.getAll` was [removed from the current WHATWG standard](https://www.fxsitecompat.com/en-CA/docs/2016/headers-getall-has-been-removed-in-favour-of-get-now-returning-all-values/), so ember-fetch doesn't implement it. Also be advised that 1.4.0 <= ember-fetch < 1.4.2 actually conflicts with ember-network due to ember-cli/ember-fetch#27, which is how I even noticed my app was including ember-network via ember-simple-network.
|
This is done on the |
ember-network also provides
fetchfromwhatwg-fetch, but it supports fastboot and browser environments.Should we deprecate this addon in favor of that one?
The text was updated successfully, but these errors were encountered: