-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import fetch from 'fetch'
not working w/ 1.4.0
#26
Comments
This fixes ember-cli#26. ember-network provides a file named vendor/fetch.js, which can overwrite the one that comes from this addon. Why would you have both ember-network and ember-fetch? In my case it was because ember-simple-auth was pulling in ember-network without my realizing.
Can you check if your app has ember-network in its dependencies? If so I think #27 solves this. |
Not explicitly, it seems that ember-simple-auth included ember-network as a dependency. From #21 I chose ember-fetch instead of ember-network for my own needs. Thanks for the quick fix guys! |
We should PR ember-simple-auth to switch to this one.
…On Wed, Apr 12, 2017 at 5:31 PM Nick Schot ***@***.***> wrote:
Not explicitly, it seems that ember-simple-auth included ember-network as
a dependency.
From #21 <#21> I chose
ember-fetch instead of ember-network for my own needs.
Thanks for the quick fix guys!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AATfMpGYZDyFDvA0V4b-tssk22bH6yN4ks5rvUKngaJpZM4M74Jl>
.
|
@ef4 and maybe fastboot too? Just stumbled upon the guide: https://ember-fastboot.com/quickstart |
We are seeing this issue in a large Fastboot project, running the latest version (3.2.8), with no dependencies running |
@BlueRaja this bug was fixed in ember-fetch version 1.4.2. If you are on that version or newer, please open a separate issue. |
Doing
import fetch from 'fetch'
throws aember.debug.js:18015 Error: Could not find module 'fetch'
on 1.4.0. Works fine on 1.3.0The text was updated successfully, but these errors were encountered: