compliance consolidation updates #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
theseyi
commented
May 23, 2017
theseyi
commented
- removes obsolete confidential feature component sources
- fixes issue with tracking current user immediately after login: moves user tracking to index from application. adds session invalidation when retrieving the current user fails. slightly refactors logout
… user tracking to index from application. adds session invalidation when retrieving the current user fails. slightly refactors logout
jgandu
approved these changes
May 23, 2017
justYves
reviewed
May 23, 2017
| @@ -1,7 +1,22 @@ | |||
| import Ember from 'ember'; | |||
| import AuthenticatedRouteMixin from 'ember-simple-auth/mixins/authenticated-route-mixin'; | |||
| import fetch from 'ember-network/fetch'; | |||
There was a problem hiding this comment.
fyi, looks like ember-fetch is replacing ember-network .
Based on conversations in miragejs/ember-cli-mirage#983, tomdale/ember-network#17 and mostly ember-cli/ember-fetch#21
justYves
approved these changes
May 23, 2017
| Ember.$.get('/logout').then(() => { | ||
| this.get('session').invalidate(); | ||
| }); | ||
| fetch('/logout').then(() => get(this, 'session').invalidate()); |
There was a problem hiding this comment.
can this call ever fail? do we need a catch ?
There was a problem hiding this comment.
If the logout fails, at this point the user will remain on the page and will probably re-attempt to logout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.