Switch from ember-network to ember-fetch #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ember-fetch is being more actively maintained and is more up-to-date with the fetch spec. See discussion in tomdale/ember-network#17 and ember-cli/ember-fetch#21 The one change I made in the tests is because `headers.getAll` was [removed from the current WHATWG standard](https://www.fxsitecompat.com/en-CA/docs/2016/headers-getall-has-been-removed-in-favour-of-get-now-returning-all-values/), so ember-fetch doesn't implement it. Also be advised that 1.4.0 <= ember-fetch < 1.4.2 actually conflicts with ember-network due to ember-cli/ember-fetch#27, which is how I even noticed my app was including ember-network via ember-simple-network.
marcoow
approved these changes
Apr 14, 2017
|
Thanks, we were just talking about this recently and now it's solved already 🎉 |
marcoow
pushed a commit
to stevenwu/ember-simple-auth
that referenced
this pull request
Apr 24, 2017
ember-fetch is being more actively maintained and is more up-to-date with the fetch spec. See discussion in tomdale/ember-network#17 and ember-cli/ember-fetch#21 The one change I made in the tests is because `headers.getAll` was [removed from the current WHATWG standard](https://www.fxsitecompat.com/en-CA/docs/2016/headers-getall-has-been-removed-in-favour-of-get-now-returning-all-values/), so ember-fetch doesn't implement it. Also be advised that 1.4.0 <= ember-fetch < 1.4.2 actually conflicts with ember-network due to ember-cli/ember-fetch#27, which is how I even noticed my app was including ember-network via ember-simple-network.
marcoow
pushed a commit
to dknutsen/ember-simple-auth
that referenced
this pull request
May 3, 2017
ember-fetch is being more actively maintained and is more up-to-date with the fetch spec. See discussion in tomdale/ember-network#17 and ember-cli/ember-fetch#21 The one change I made in the tests is because `headers.getAll` was [removed from the current WHATWG standard](https://www.fxsitecompat.com/en-CA/docs/2016/headers-getall-has-been-removed-in-favour-of-get-now-returning-all-values/), so ember-fetch doesn't implement it. Also be advised that 1.4.0 <= ember-fetch < 1.4.2 actually conflicts with ember-network due to ember-cli/ember-fetch#27, which is how I even noticed my app was including ember-network via ember-simple-network.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-fetch is being more actively maintained and is more up-to-date with the fetch spec.
See discussion in tomdale/ember-network#17 and ember-cli/ember-fetch#21
The one change I made in the tests is because
headers.getAllwas removed from the current WHATWG standard, so ember-fetch doesn't implement it.