Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw the API exception with authorisation URL on SCMunauthorised error #621

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Dec 1, 2023

What does this PR do?

Fixes a bug with broken oauth flow caused by #615.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#22715

How to test this PR?

  1. Deploy che from the PR image: quay.io/eclipse/che-server:pr-621
  2. Configure GitHub oauth flow.
  3. Start a workspace from a GitHub repository.

See: workspace starts successfully.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@vinokurig
Copy link
Contributor Author

/retest

1 similar comment
@vinokurig
Copy link
Contributor Author

/retest

@ibuziuk ibuziuk requested a review from artaleks9 December 4, 2023 08:51
@artaleks9
Copy link
Contributor

Verified on Che deployed using quay.io/eclipse/che-server:pr-621 - works as expected.

Copy link

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, ibuziuk, tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig vinokurig merged commit ebca103 into main Dec 4, 2023
@vinokurig vinokurig deleted the che-22715 branch December 4, 2023 18:57
@devstudio-release
Copy link

Build 3.11 :: server_3.x/290: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: server_3.x/290: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5497 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2255: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5498: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5377 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.11 :: operator-bundle_3.x/2361: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5498 triggered

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1627: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/5127: SUCCESS

Detected new images: rebuild operator-bundle
* server; /DS_CI/operator-bundle_3.x/2361 triggered

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1627: SUCCESS

3.11.0-CI

vinokurig added a commit that referenced this pull request Dec 5, 2023
…or (#621)

Fixes a bug with broken oauth flow caused by #615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace from private bitbucket-server repository failing to start using oAuth-1
5 participants