Throw the API exception with authorization URL on SCMunauthorised err…

…or (#621) Fixes a bug with broken oauth flow caused by #615
eclipse-che · Dec 5, 2023 · 7f83f5f · 7f83f5f
1 parent c47c7f6
commit 7f83f5f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/...actory/src/main/java/org/eclipse/che/api/factory/server/urlfactory/URLFactoryBuilder.java b/...actory/src/main/java/org/eclipse/che/api/factory/server/urlfactory/URLFactoryBuilder.java
@@ -30,6 +30,7 @@
 import javax.inject.Singleton;
 import org.eclipse.che.api.core.ApiException;
 import org.eclipse.che.api.core.BadRequestException;
+import org.eclipse.che.api.factory.server.scm.exception.ScmUnauthorizedException;
 import org.eclipse.che.api.factory.server.urlfactory.RemoteFactoryUrl.DevfileLocation;
 import org.eclipse.che.api.factory.shared.dto.FactoryDevfileV2Dto;
 import org.eclipse.che.api.factory.shared.dto.FactoryDto;
@@ -131,7 +132,9 @@ public Optional<FactoryMetaDto> createFactoryFromDevfile(
         continue;
       } catch (DevfileException e) {
         LOG.debug("Unexpected devfile exception: {}", e.getMessage());
-        throw new ApiException(e.getMessage());
+        throw e.getCause() instanceof ScmUnauthorizedException
+            ? toApiException(e, location)
+            : new ApiException(e.getMessage());
       }
       if (isNullOrEmpty(devfileYamlContent)) {
         return Optional.empty();

diff --git a/...ry/src/test/java/org/eclipse/che/api/factory/server/urlfactory/URLFactoryBuilderTest.java b/...ry/src/test/java/org/eclipse/che/api/factory/server/urlfactory/URLFactoryBuilderTest.java
@@ -451,7 +451,7 @@ public String location() {
     } catch (ApiException e) {
       assertTrue(e.getClass().isAssignableFrom(expectedClass));
       assertEquals(e.getMessage(), expectedMessage);
-      if (e.getServiceError() instanceof ExtendedError)
+      if ("SCM Authentication required".equals(e.getMessage()))
         assertEquals(((ExtendedError) e.getServiceError()).getAttributes(), expectedAttributes);
     }
   }