Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the unreachable devfile exception message #615

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Align the unreachable devfile exception message #615

merged 3 commits into from
Nov 28, 2023

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Nov 20, 2023

What does this PR do?

Add a common exception message and use it for cases when:

  • The devfile location is unavailable.
  • The devfile content is is not valid: e.g the response content is an html content of an scm authorisation page.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#22469

How to test this PR?

  1. Deploy che from the PR image: quay.io/eclipse/che-server:pr-615
  2. Start a workspace from a private GitHub repo, see the error:
    screenshot-192 168 64 214 nip io-2023 11 20-15_17_57
  3. Start a workspace from a private azure-devops repo, see the error in the same format:
    screenshot-192 168 64 214 nip io-2023 11 20-15_18_37

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@vinokurig
Copy link
Contributor Author

/retest

3 similar comments
@vinokurig
Copy link
Contributor Author

/retest

@artaleks9
Copy link
Contributor

/retest

@vinokurig
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the lgtm label Nov 23, 2023
@artaleks9
Copy link
Contributor

Copy link

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@artaleks9
Copy link
Contributor

/retest

@vinokurig vinokurig merged commit 5baa3a7 into main Nov 28, 2023
@vinokurig vinokurig deleted the che-22469 branch November 28, 2023 16:09
@devstudio-release
Copy link

Build 3.11 :: server_3.x/285: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: server_3.x/286: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: server_3.x/286: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5410 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: server_3.x/285: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5411 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/5051: UNSTABLE

No new images detected: nothing to do!

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/5052: UNSTABLE

No new images detected: nothing to do!

vinokurig added a commit that referenced this pull request Dec 4, 2023
…or (#621)

Fixes a bug with broken oauth flow caused by #615
vinokurig added a commit that referenced this pull request Dec 5, 2023
…or (#621)

Fixes a bug with broken oauth flow caused by #615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confused behavior run workspace when use factory from azure-devops private repository without PAT/OAuth setup
4 participants