Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable flaky test #3283

Merged
merged 1 commit into from
Aug 27, 2024
Merged

disable flaky test #3283

merged 1 commit into from
Aug 27, 2024

Conversation

SabrinaTardio
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1204186595873227/1207233637905252/f
Tech Design URL:
CC:

Description: Disabling a test until I have time to review it

Steps to test this PR:
1.
2.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SabrinaTardio SabrinaTardio merged commit 5ca931e into main Aug 27, 2024
13 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/disable-test branch August 27, 2024 16:45
samsymons added a commit that referenced this pull request Aug 28, 2024
# By Anh Do (2) and others
# Via Bartek Waresiak (2) and GitHub (1)
* main:
  Add PPro unified feedback form (#3248)
  disable flaky test (#3283)
  Unified feedback form for Privacy Pro (#3172)
  Release 7.135.0-1 (#3280)
  fix back forward swipe gesture in landscape (#3278)
  Set onboarding completed for sync end to end tests (#3259)
  Release 7.135.0-0 (#3277)
  BSK Bump for macOS Freemium PIR RMF Attribute (No iOS Impact) (#3275)
  Fix math expressions on address bar (#3262)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Aug 29, 2024
# By Daniel Bernal (4) and others
# Via Bartek Waresiak (2) and others
* main: (32 commits)
  Add error pixels for Subscription keychain access errors (#3276)
  [DuckPlayer] 24. FrontEnd Translation (#3281)
  [DuckPlayer] 23. Ship Review Fixes (#3279)
  Logging refactoring phase #2 (#3268)
  Move WireGuard dependency to packet tunnel provider (#3273)
  Add PPro unified feedback form (#3248)
  disable flaky test (#3283)
  Unified feedback form for Privacy Pro (#3172)
  Release 7.135.0-1 (#3280)
  fix back forward swipe gesture in landscape (#3278)
  Set onboarding completed for sync end to end tests (#3259)
  Release 7.135.0-0 (#3277)
  BSK Bump for macOS Freemium PIR RMF Attribute (No iOS Impact) (#3275)
  Fix math expressions on address bar (#3262)
  fix progress view crash by removing call to flush (#3272)
  Update autoconsent to v10.15.0 (#3254)
  Mitigate Onboarding pixels firing with empty atb (#3265)
  Clean up legacy VPN navigation (#3266)
  Re-Enable Broken Site Toast on iOS (#3244)
  Bump BSK (No iOS Changes) (#3261)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants