Feature/port objc to swift #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: DOES NOT COMPILE!
Project now in a basic compiling state. The utilities removed will be fixed and brought back into project one at a time as needed
Gets app into a barebones / clean state. Utilities removed may be brought back in the future as needed
* Add browser with with private browsing via persistent data store * Add launch screen * Remove non-compiling / unused code (utilities removed will be brought back into the project one at a time, as needed)
• Hide nav bars when scrolling • Better button arrangement • Add functionality to open current link in safari
…uckgo-iOS into feature/port_objc_to_swift
…aviour search bar compression still needs adjustment for the status bar long-tap on images implemented but not tested lots of little fiddlings with xib files, etc
…uckgo-iOS into feature/port_objc_to_swift
Merged
13 tasks
8 tasks
13 tasks
13 tasks
14 tasks
federicocappelli
added a commit
that referenced
this pull request
Aug 22, 2024
federicocappelli
added a commit
that referenced
this pull request
Aug 28, 2024
Task/Issue URL: https://app.asana.com/0/1205842942115003/1206750146033742/f Tech Design URL: https://app.asana.com/0/1200194497630846/1206777133329590/f **Description**: Now logging is aligned with our guideline: https://app.asana.com/0/1202500774821704/1208001254061393/f - all OSLog wrappers removed - all os_log uses removed and replaced with Logger - ability to disable logs from the app removed - Local and shared Logger improved
samsymons
added a commit
that referenced
this pull request
Aug 29, 2024
# By Daniel Bernal (4) and others # Via Bartek Waresiak (2) and others * main: (32 commits) Add error pixels for Subscription keychain access errors (#3276) [DuckPlayer] 24. FrontEnd Translation (#3281) [DuckPlayer] 23. Ship Review Fixes (#3279) Logging refactoring phase #2 (#3268) Move WireGuard dependency to packet tunnel provider (#3273) Add PPro unified feedback form (#3248) disable flaky test (#3283) Unified feedback form for Privacy Pro (#3172) Release 7.135.0-1 (#3280) fix back forward swipe gesture in landscape (#3278) Set onboarding completed for sync end to end tests (#3259) Release 7.135.0-0 (#3277) BSK Bump for macOS Freemium PIR RMF Attribute (No iOS Impact) (#3275) Fix math expressions on address bar (#3262) fix progress view crash by removing call to flush (#3272) Update autoconsent to v10.15.0 (#3254) Mitigate Onboarding pixels firing with empty atb (#3265) Clean up legacy VPN navigation (#3266) Re-Enable Broken Site Toast on iOS (#3244) Bump BSK (No iOS Changes) (#3261) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
14 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bring over the core code from old objective-C app and translate it into swift