Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump BSK (No iOS Changes) #3261

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Bump BSK (No iOS Changes) #3261

merged 2 commits into from
Aug 22, 2024

Conversation

aataraxiaa
Copy link
Contributor

@aataraxiaa aataraxiaa commented Aug 21, 2024

Task/Issue URL: https://app.asana.com/0/1206488453854252/1208052452067291/f
Tech Design URL:
CC:

Description: Bump BSK (no iOS changes, BSK change is only a macOS specific new subfeature flag)

Steps to test this PR:

  1. Green CI

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

aataraxiaa added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Aug 22, 2024
Task/Issue URL:
https://app.asana.com/0/1206488453854252/1208052452067291/f
iOS PR: duckduckgo/iOS#3261
macOS PR: duckduckgo/macos-browser#3129
What kind of version bump will this require?: Patch

**Description**: Adds PIR Freemium Subfeature
@aataraxiaa aataraxiaa merged commit 3f030f0 into main Aug 22, 2024
13 checks passed
@aataraxiaa aataraxiaa deleted the pete/bump-bsk-version branch August 22, 2024 08:50
samsymons added a commit that referenced this pull request Aug 29, 2024
# By Daniel Bernal (4) and others
# Via Bartek Waresiak (2) and others
* main: (32 commits)
  Add error pixels for Subscription keychain access errors (#3276)
  [DuckPlayer] 24. FrontEnd Translation (#3281)
  [DuckPlayer] 23. Ship Review Fixes (#3279)
  Logging refactoring phase #2 (#3268)
  Move WireGuard dependency to packet tunnel provider (#3273)
  Add PPro unified feedback form (#3248)
  disable flaky test (#3283)
  Unified feedback form for Privacy Pro (#3172)
  Release 7.135.0-1 (#3280)
  fix back forward swipe gesture in landscape (#3278)
  Set onboarding completed for sync end to end tests (#3259)
  Release 7.135.0-0 (#3277)
  BSK Bump for macOS Freemium PIR RMF Attribute (No iOS Impact) (#3275)
  Fix math expressions on address bar (#3262)
  fix progress view crash by removing call to flush (#3272)
  Update autoconsent to v10.15.0 (#3254)
  Mitigate Onboarding pixels firing with empty atb (#3265)
  Clean up legacy VPN navigation (#3266)
  Re-Enable Broken Site Toast on iOS (#3244)
  Bump BSK (No iOS Changes) (#3261)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants