Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PPro unified feedback form #3248

Merged
merged 33 commits into from
Aug 27, 2024
Merged

Add PPro unified feedback form #3248

merged 33 commits into from
Aug 27, 2024

Conversation

quanganhdo
Copy link
Member

@quanganhdo quanganhdo commented Aug 16, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/414235014887631/1207701941801991/f
Tech Design URL:
CC:

Description:

This adds PPro unified feedback form to iOS

Steps to test this PR:

  1. Check Settings > Share Feedback, the existing flow should work
  2. Make sure you have a PPro subscription
  3. Go to Settings > Subscription Settings, the last menu item should be FAQs and Support
  4. Go to Settings > VPN > Share VPN Feedback, the existing flow should work
  5. Log in as internal user, use this for the privacy config: http://www.jsonblob.com/api/1274015132613992448
  6. Settings > Send Feedback should now let you choose between the current browser feedback and PPro feedback form. Play with the form and see if it works
  7. Settings > Subscription Settings, the last menu item should now be Send Feedback, again check if the flow works
  8. Settings > VPN > Send feedback, this should use the new unified flow.

Smoke test these pixels as you go through the flow: https://app.asana.com/0/72649045549333/1207816523739193/f

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

quanganhdo added 19 commits August 6, 2024 13:30
@quanganhdo
Update BSK
74bf930
@quanganhdo
Placeholder
db86fbb
@quanganhdo
View draft
4918a69
@quanganhdo
Roughly connect things together
aca1d2d
@quanganhdo
Refactor
288fb07
@quanganhdo
Draft entry point
7ba1a98
@quanganhdo
Refactor
badb87f
@quanganhdo
Add entry point
3864e1c
@quanganhdo
Update copy
1304f7d
@quanganhdo
Update style
280899e
@quanganhdo
Fire pixels
b4aed49
@quanganhdo
Dismiss
9cf91f3
@quanganhdo
Link to FAQ, placeholder, copy update
4920efa
@quanganhdo
Refactor & fix background color
9eb136f
@quanganhdo
Fix Swiftlint
33d2981
@quanganhdo
Fix styling
2f861ad
@quanganhdo
Enable flag check
b62ad74
@quanganhdo
Update copy
6739a35
@quanganhdo
Merge branch 'main' into anh/ppro/unified-feedback-ios
06768e3 
# Conflicts:
#	Core/PixelEvent.swift
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/NetworkProtectionStatusViewModel.swift
#	DuckDuckGo/Subscription/ViewModel/SubscriptionSettingsViewModel.swift
#	DuckDuckGo/Subscription/Views/SubscriptionSettingsView.swift
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 13bf47c

@quanganhdo quanganhdo requested a review from samsymons August 21, 2024 04:41
@quanganhdo
Remove debug button
055f6d2
@quanganhdo
Merge branch 'main' into anh/ppro/unified-feedback-ios
68ee112 
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@quanganhdo
Revert auto push behavior
fa9ef3b
@quanganhdo
Fix typo
09c6523
@quanganhdo
Update BSK
83a08d9
@quanganhdo
Merge branch 'main' into anh/ppro/unified-feedback-ios
e58b1e5 
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
@quanganhdo
Make usesUnifiedFeedbackForm dynamic
13bf47c
samsymons
samsymons approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ran through the form for each feature to check that the messages/categories/metadata all look good, tested the flow on different devices, checked that the form can't be submitted repeatedly, all looks to be working well.

@quanganhdo quanganhdo merged commit 29f8770 into main Aug 27, 2024
13 checks passed
@quanganhdo quanganhdo deleted the anh/ppro/unified-feedback-ios branch August 27, 2024 18:09
samsymons added a commit that referenced this pull request Aug 28, 2024
@samsymons
Merge branch 'main' into sam/remove-wireguard-dependency
d1a952f 
# By Anh Do (2) and others
# Via Bartek Waresiak (2) and GitHub (1)
* main:
  Add PPro unified feedback form (#3248)
  disable flaky test (#3283)
  Unified feedback form for Privacy Pro (#3172)
  Release 7.135.0-1 (#3280)
  fix back forward swipe gesture in landscape (#3278)
  Set onboarding completed for sync end to end tests (#3259)
  Release 7.135.0-0 (#3277)
  BSK Bump for macOS Freemium PIR RMF Attribute (No iOS Impact) (#3275)
  Fix math expressions on address bar (#3262)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Aug 29, 2024
@samsymons
Merge branch 'main' into diego/domain-exclusion-improvements
fb16ec6 
# By Daniel Bernal (4) and others
# Via Bartek Waresiak (2) and others
* main: (32 commits)
  Add error pixels for Subscription keychain access errors (#3276)
  [DuckPlayer] 24. FrontEnd Translation (#3281)
  [DuckPlayer] 23. Ship Review Fixes (#3279)
  Logging refactoring phase #2 (#3268)
  Move WireGuard dependency to packet tunnel provider (#3273)
  Add PPro unified feedback form (#3248)
  disable flaky test (#3283)
  Unified feedback form for Privacy Pro (#3172)
  Release 7.135.0-1 (#3280)
  fix back forward swipe gesture in landscape (#3278)
  Set onboarding completed for sync end to end tests (#3259)
  Release 7.135.0-0 (#3277)
  BSK Bump for macOS Freemium PIR RMF Attribute (No iOS Impact) (#3275)
  Fix math expressions on address bar (#3262)
  fix progress view crash by removing call to flush (#3272)
  Update autoconsent to v10.15.0 (#3254)
  Mitigate Onboarding pixels firing with empty atb (#3265)
  Clean up legacy VPN navigation (#3266)
  Re-Enable Broken Site Toast on iOS (#3244)
  Bump BSK (No iOS Changes) (#3261)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsymons samsymons samsymons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quanganhdo @samsymons