fix: AUT Redirect bug on form / anchor target #16394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…io/cypress into tgriesser/fix/3975-redirect-bug * 'tgriesser/fix/3975-redirect-bug' of github.com:cypress-io/cypress: fix(@cypress/webpack-batteries-included-preprocessor): Ensure typescript options are set if typescript path is provided (#15991) chore: release @cypress/vite-dev-server-v1.2.2 fix: conditionally require vue and update alias if installed (#16000) docs: remove cssFiles from the vue documentation (#15971) chore: release @cypress/webpack-dev-server-v1.1.3 chore: release @cypress/vite-dev-server-v1.2.1 chore: release @cypress/react-v5.3.3 fix: remove lazy-compile-webpack-plugin (#15964)
* develop: (49 commits) fix: `cy.type()` should not change the value attr of button-like inputs. (#16154) fix: properly detect `cy.intercept(url, routeMatcher, handler)` overload (#16167) fix: consider multiple routes when looking for aliases (#16180) fix: pass contextIsolation: true (#16165) chore: fix failing "should handle aborted requests" test (#16170) feat(issue-3741): added keyboard support for folder (#15648) fix(webpack-dev-server): remove hard dependency on html-webpack-plugin v4 (#16108) chore(deps): downgrade electron to v12.0.0-beta.14 (#16113) fix: accept absolute paths in vite dev server (#16148) fix: cy.then shows wrong type when collection of HTMLElement's is provided (#15869) fix: do not treat utf8 requests as binary (#15946) chore: fix types docs: fix broken links for @cypress/react example recipes (#15674) update circle yml ignore undefined beforeEach fix: make vite-dev-server work on windows (#16103) chore: add triple slash reference chore: remove conflicting types chore: rebuild yarn lock resolve conflicts in master(fe0b63c) and develop ...
|
Thanks for taking the time to open a PR!
|
5 tasks
tgriesser
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
* develop: (28 commits) fix: XHR event listener AUT redirect bug (#15995) chore: fix typo (#16345) chore(design-system): Added missing exports and index.ts (#16351) chore: Remove extra renovate.json file (#16385) Do not print 'uploading' stdout when --quiet mode is passed (#16271) fix(deps): update dependency color-string to version 1.5.5 🌟 (#16362) fix(deps): update dependency cypress-real-events to version 1.4.0 🌟 (#16363) tests: use the proper keys for selecting framework fix: Prevent Firefox from opening custom search when pressing / (#16372) fix(socket): update serialization for circular binary socket messages (#16311) fix: vueCli and webpack key vue@2 fix when guessing tests: update snapshots fix: add return config for vueCli and vueWebpack chore(deps): update dependency classnames to version 2.3.1 🌟 (#8337) fix: add return config for vitejs templates chore: release @cypress/vue-v2.2.2 chore: release @cypress/react-v5.5.0 fix: remove all of rollup, not supported anymore fix: typo in the final message (run vs run-ct) fix: use close event when asking the browser for its version (#16312) ...
tgriesser
requested review from
flotwig and
brian-mann
and removed request for
a team
brian-mann
requested changes
May 7, 2021
* develop: remove unused deps from webpack-preprocessor (#16384) feat: exclude html pwa plugin in webpack dev server (#16388) fix(ui): display duplicate aliases in command log (#16382) fix(ui): show req stub/fn when a handler is supplied (#16383) feat(component-testing): Expose CT through CLI module API (#16368)
chrisbreiding
approved these changes
May 10, 2021
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Adds code to detect when a form submit or anchor tag target is set to
_top/_parent, setting to''to avoid redirecting the parent frame. Maintains behavior fortarget=_blank&target=_self, as these have no effect on test execution.Additional details
Split out from where it was originally added in #15995
How has the user experience changed?
User's AUT is no-longer redirected incorrectly to
/__and instead maintains the correct window location path.PR Tasks
cypress-documentation?type definitions?cypress.schema.json?