Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(design-system): Added missing exports and index.ts #16351

Merged
merged 7 commits into from
May 7, 2021

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented May 5, 2021

Very minor change. Just adds missing component exports.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 5, 2021

Thanks for taking the time to open a PR!

elevatebart
elevatebart previously approved these changes May 5, 2021
Copy link
Contributor

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the small comment, LGTM

npm/design-system/src/util/types.ts Show resolved Hide resolved
@cypress
Copy link

cypress bot commented May 5, 2021



Test summary

4034 0 53 1Flakiness 0


Run details

Project cypress
Status Passed
Commit c305d6e
Started May 7, 2021 1:43 PM
Ended May 7, 2021 1:54 PM
Duration 10:50 💡
OS Linux Debian - 10.8
Browser Firefox 77

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

lmiller1990
lmiller1990 previously approved these changes May 6, 2021
@agg23 agg23 dismissed stale reviews from lmiller1990 and elevatebart via 7d6ffbf May 6, 2021 14:50
@lmiller1990 lmiller1990 self-requested a review May 7, 2021 15:15
@agg23 agg23 merged commit 4aeefd7 into develop May 7, 2021
tgriesser added a commit that referenced this pull request May 7, 2021
* develop: (28 commits)
  fix: XHR event listener AUT redirect bug (#15995)
  chore: fix typo (#16345)
  chore(design-system): Added missing exports and index.ts (#16351)
  chore: Remove extra renovate.json file (#16385)
  Do not print 'uploading' stdout when --quiet mode is passed (#16271)
  fix(deps): update dependency color-string to version 1.5.5 🌟 (#16362)
  fix(deps): update dependency cypress-real-events to version 1.4.0 🌟 (#16363)
  tests: use the proper keys for selecting framework
  fix: Prevent Firefox from opening custom search when pressing / (#16372)
  fix(socket): update serialization for circular binary socket messages (#16311)
  fix: vueCli and webpack key vue@2 fix when guessing
  tests: update snapshots
  fix: add return config for vueCli and vueWebpack
  chore(deps): update dependency classnames to version 2.3.1 🌟 (#8337)
  fix: add return config for vitejs templates
  chore: release @cypress/vue-v2.2.2
  chore: release @cypress/react-v5.5.0
  fix: remove all of rollup, not supported anymore
  fix: typo in the final message (run vs run-ct)
  fix: use close event when asking the browser for its version (#16312)
  ...
agg23 added a commit that referenced this pull request May 7, 2021
fix(deps): update dependency cypress-real-events to version 1.4.0 🌟 (#16363)

Co-authored-by: Renovate Bot <[email protected]>

fix: typo in the final message (run vs run-ct)

fix: remove all of rollup, not supported anymore

fix: add return config for vitejs templates

fix: add return config for vueCli and vueWebpack

tests: update snapshots

fix: vueCli and webpack key vue@2 fix when guessing

tests: use the proper keys for selecting framework

chore: release @cypress/react-v5.5.0

[skip ci]

chore: release @cypress/vue-v2.2.2

[skip ci]

fix(deps): update dependency color-string to version 1.5.5 🌟 (#16362)

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Jennifer Shehane <[email protected]>

Do not print 'uploading' stdout when --quiet mode is passed (#16271)

chore: Remove extra renovate.json file (#16385)

chore(design-system): Added missing exports and index.ts (#16351)

chore: fix typo (#16345)

Co-authored-by: Jennifer Shehane <[email protected]>

fix: XHR event listener AUT redirect bug (#15995)

Fixes incorrect redirect when location.href is set to a relative path within the call stack of an XHR event handler, which set the user's AUT to /__/ rather than the correct path

Linting after merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants