Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept absolute paths in vite dev server #16148

Merged
merged 4 commits into from
Apr 22, 2021

Conversation

elevatebart
Copy link
Contributor

This PR contains the repairs of a regression introduced in this commit

Changing the src of the AUT iframe from realtive to absolute made it necessary for vite-dev-erver to change its behavior.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 22, 2021

Thanks for taking the time to open a PR!

@elevatebart elevatebart requested a review from lmiller1990 April 22, 2021 16:48
@cypress
Copy link

cypress bot commented Apr 22, 2021



Test summary

9495 0 111 3Flakiness 0


Run details

Project cypress
Status Passed
Commit 2e5f18a
Started Apr 22, 2021 6:34 PM
Ended Apr 22, 2021 6:46 PM
Duration 12:15 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@elevatebart elevatebart merged commit 684730f into develop Apr 22, 2021
tgriesser added a commit that referenced this pull request Apr 26, 2021
* develop: (49 commits)
  fix: `cy.type()` should not change the value attr of button-like inputs. (#16154)
  fix: properly detect `cy.intercept(url, routeMatcher, handler)` overload (#16167)
  fix: consider multiple routes when looking for aliases (#16180)
  fix: pass contextIsolation: true (#16165)
  chore: fix failing "should handle aborted requests" test (#16170)
  feat(issue-3741): added keyboard support for folder (#15648)
  fix(webpack-dev-server): remove hard dependency on html-webpack-plugin v4  (#16108)
  chore(deps): downgrade electron to v12.0.0-beta.14 (#16113)
  fix: accept absolute paths in vite dev server (#16148)
  fix: cy.then shows wrong type when collection of HTMLElement's is provided (#15869)
  fix: do not treat utf8 requests as binary (#15946)
  chore: fix types
  docs: fix broken links for @cypress/react example recipes (#15674)
  update circle yml
  ignore undefined beforeEach
  fix: make vite-dev-server work on windows (#16103)
  chore: add triple slash reference
  chore: remove conflicting types
  chore: rebuild yarn lock
  resolve conflicts in master(fe0b63c) and develop
  ...
@emilyrohrbough emilyrohrbough deleted the fix/vite-absolute-path branch August 1, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants