fix: do not treat utf8 requests as binary #15946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
|
Hmm, the integration test does not fail even for previous settings, really want to see a failing test first |
bahmutov
commented
Apr 13, 2021
|
The e2e test fails without the fix, passes with the fix |
|
Internal Jira issue: TR-749 |
Co-authored-by: Zach Bloomquist <[email protected]>
|
Is there as known workarround? |
|
flotwig
approved these changes
Apr 22, 2021
tgriesser
added a commit
that referenced
this pull request
Apr 26, 2021
* develop: (49 commits) fix: `cy.type()` should not change the value attr of button-like inputs. (#16154) fix: properly detect `cy.intercept(url, routeMatcher, handler)` overload (#16167) fix: consider multiple routes when looking for aliases (#16180) fix: pass contextIsolation: true (#16165) chore: fix failing "should handle aborted requests" test (#16170) feat(issue-3741): added keyboard support for folder (#15648) fix(webpack-dev-server): remove hard dependency on html-webpack-plugin v4 (#16108) chore(deps): downgrade electron to v12.0.0-beta.14 (#16113) fix: accept absolute paths in vite dev server (#16148) fix: cy.then shows wrong type when collection of HTMLElement's is provided (#15869) fix: do not treat utf8 requests as binary (#15946) chore: fix types docs: fix broken links for @cypress/react example recipes (#15674) update circle yml ignore undefined beforeEach fix: make vite-dev-server work on windows (#16103) chore: add triple slash reference chore: remove conflicting types chore: rebuild yarn lock resolve conflicts in master(fe0b63c) and develop ...
brian-mann
reviewed
May 4, 2021
Comment on lines
+1321
to
+1322
| cy.intercept('POST', 'http://localhost:5000/api/sample') | ||
| cy.visit('/fixtures/utf8-post.html') |
There was a problem hiding this comment.
Since the fetch(...) is async you need to cy.wait(...) for the intercept to finish otherwise there's a race condition where the test could finish before the fetch() does and lead to a false negative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
We were incorrectly detecting "normal" utf8 request body as binary encoding, which caused the test runner crash. The detection was caused by multi-byte Unicode characters in some languages.
Additional details
PS: there is an open issue for the existing module we use to detect the encoding bevry/istextorbinary#13 which exactly matches our issue.
How has the user experience changed?
No more crashing in the provided reproducible example
PR Tasks