Improve header 3 #605
Improve header 3 #605
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
| @@ -63,7 +63,7 @@ import { SwapVCowStatus } from 'state/cowToken/actions' | |||
| import LockedGnoVesting from './LockedGnoVesting' | |||
| import useBlockNumber from 'lib/hooks/useBlockNumber' | |||
| import usePrevious from 'hooks/usePrevious' | |||
| import { useCowFromLockedGnoBalances } from 'pages/Profile/LockedGnoVesting/hooks' | |||
| import { useCowFromLockedGnoBalances } from '@src/custom/pages/Account/LockedGnoVesting/hooks' | |||
There was a problem hiding this comment.
Should the imports here (line 27 and 66) be from @srcpages/custom/pages/Account rather than pages/Account?
There was a problem hiding this comment.
Yes you're right. I believe this has been fixed in improve-header-12 (last branch).
| @@ -20,7 +20,7 @@ const PrivacyPolicy = lazy(() => import(/* webpackChunkName: "privacy_policy" */ | |||
| const CookiePolicy = lazy(() => import(/* webpackChunkName: "cookie_policy" */ 'pages/CookiePolicy')) | |||
| const TermsAndConditions = lazy(() => import(/* webpackChunkName: "terms" */ 'pages/TermsAndConditions')) | |||
| const About = lazy(() => import(/* webpackChunkName: "about" */ 'pages/About')) | |||
| const Profile = lazy(() => import(/* webpackChunkName: "profile" */ 'pages/Profile')) | |||
| const Account = lazy(() => import(/* webpackChunkName: "profile" */ '@src/custom/pages/Account')) | |||
There was a problem hiding this comment.
| const Account = lazy(() => import(/* webpackChunkName: "profile" */ '@src/custom/pages/Account')) | |
| const Account = lazy(() => import(/* webpackChunkName: "profile" */ 'pages/Account')) |
There was a problem hiding this comment.
This is how it looks like in the last branch (improve-header-12)
const Account = lazy(() => import(/* webpackChunkName: "profile" */ '@src/custom/pages/Account'))
Let me know if that should be changed to your suggestion:
const Account = lazy(() => import(/* webpackChunkName: "profile" */ 'pages/Account'))
There was a problem hiding this comment.
Ah I see.
I'd that, unless it doesn't work without @src/custom, prefer the relative path
| history.push('/profile' + location.search) | ||
| history.push('/account' + location.search) |
There was a problem hiding this comment.
I'd add a note here to update the path with @nenadV91 's changes where affiliate has it's own subpath now
| <StyledNavLink to="/profile">Profile</StyledNavLink> | ||
| <StyledNavLink to="/account">Account</StyledNavLink> | ||
| <StyledNavLink to="/faq">FAQ</StyledNavLink> | ||
| <StyledNavLink to="/swap">More</StyledNavLink> |
There was a problem hiding this comment.
Updated in the last PR (#596)
* Switch to custom MenuDropdown compontent and create a POC. * Improve header 5 (#603) * Improve FAQ text * Improve header 6 (#602) * connect button styling * Further flyout menu styling * Improve header 7 (#601) * Further flyout menu styling * Uniform menu items styling * Move styled components to styled * Add hamburger icon with animation component. * Improve header 8 (#600) * Add mediaQuery hook * Improve header 9 (#599) * Progress mobile responsive menu * Progress mobile responsive menu * Improve header 10 (#598) * Move to helper function * Optimise menu code * Improve header 11 (#597) * Move URLS to an ENUM * Fix enum issue. * Styling and route fixes. * Styling. * Styling. * Header/Menu improvement (waterfall PR FINAL) (#596) * Styling. * Styling footer and bridge banner. * Improve header 13 (#610) * Fix network selector position. * Fix exports/imports for network selector. * Only open ordersPanel if account is true.
Summary
/profileroutes to use/accountinstead. Puts a redirect in place.Accountinstead.