Improve header 13 #610
Merged
Improve header 13 #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
alfetopito
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
The reported issues were fixed.
There is one other issue that I noticed before and now I understand why.
Not such a big deal as I don't think this is a real world use case, but mentioning just in case
- Load the page on desktop
- Switch it to mobile view
- Click on Network dropdown
- Nothing happens
Screen.Recording.2022-06-01.at.10.26.12.mov
The other way around also breaks
- From
2, refresh the page - Click on the network dropdown
- The network switcher shows up
- Disable the mobile view (go back to desktop mode)
- Hover over network switcher
- Nothing happens
|
@alfetopito Thanks for checking, I will make sure to review that once fully consolidated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses general feedback on the waterfall PRs:
ordersPanelifaccountis true. There was a bug where on click of 'CONNECT A WALLET' it would open the orderspanel + connect a wallet modal (@nenadV91 )