-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header/Menu improvement (waterfall PR FINAL) #596
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
|
Got a failed cypress test:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find there. I think I'll apply a simple fix for now, until I make it an actual 'mobile' like menu.
In this state you showed me, yes there's space. But a few things to consider:
All of this can be optimized for individually (eg ellipsis or number abbreviation), but keeping a safe margin here seems sensible from that point of view. |
* Fix network selector position. * Fix exports/imports for network selector. * Only open ordersPanel if account is true.
Summary
This branch
improve-header-12
is the last in the waterfall PR to improve the header/menu for all viewports:Screen.Recording.2022-05-30.at.16.13.24.mov
Screen.Recording.2022-05-30.at.16.59.46.mov
Screen.Recording.2022-05-30.at.16.13.05.mov
Screen.Recording.2022-05-30.at.16.12.36.mov
Screen.Recording.2022-05-30.at.16.12.05.mov
Screen.Recording.2022-05-30.at.16.11.29.mov
Screen.Recording.2022-05-30.at.17.01.07.mov
Todo for future PRs: