-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve header 3 #605
Improve header 3 #605
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -80,7 +80,7 @@ const StyledNavLink = styled(StyledNavLinkUni)` | |
|
||
const BalanceText = styled(BalanceTextUni)` | ||
font-weight: 500; | ||
padding: 0 12px; | ||
padding: 0 0 0 12px; | ||
|
||
${({ theme }) => theme.mediaWidth.upToMedium` | ||
overflow: hidden; | ||
|
@@ -228,6 +228,10 @@ const AccountElement = styled(AccountElementUni)<{ active: boolean }>` | |
&:focus { | ||
border: 1px solid ${({ theme }) => transparentize(0.4, theme.text1)}; | ||
} | ||
|
||
${BalanceText} { | ||
min-width: initial; | ||
} | ||
` | ||
|
||
export default function Header() { | ||
|
@@ -249,7 +253,7 @@ export default function Header() { | |
const isMenuOpen = useModalOpen(ApplicationModal.MENU) | ||
|
||
const history = useHistory() | ||
const handleBalanceButtonClick = () => history.push('/profile') | ||
const handleBalanceButtonClick = () => history.push('/account') | ||
|
||
// Toggle the 'noScroll' class on body, whenever the orders panel or flyout menu is open. | ||
// This removes the inner scrollbar on the page body, to prevent showing double scrollbars. | ||
|
@@ -273,7 +277,9 @@ export default function Header() { | |
</Title> | ||
<HeaderLinks> | ||
<StyledNavLink to="/swap">Swap</StyledNavLink> | ||
<StyledNavLink to="/profile">Profile</StyledNavLink> | ||
<StyledNavLink to="/account">Account</StyledNavLink> | ||
<StyledNavLink to="/faq">FAQ</StyledNavLink> | ||
<StyledNavLink to="/swap">More</StyledNavLink> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. More goes to swap? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated in the last PR (#596) |
||
</HeaderLinks> | ||
</HeaderRow> | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,7 @@ import { | |
BannerCardSvg, | ||
CardsLoader, | ||
CardsSpinner, | ||
} from 'pages/Profile/styled' | ||
} from '@src/custom/pages/Account/styled' | ||
import { useActiveWeb3React } from 'hooks/web3' | ||
import Copy from 'components/Copy/CopyMod' | ||
import { RefreshCcw } from 'react-feather' | ||
|
@@ -63,7 +63,7 @@ import { SwapVCowStatus } from 'state/cowToken/actions' | |
import LockedGnoVesting from './LockedGnoVesting' | ||
import useBlockNumber from 'lib/hooks/useBlockNumber' | ||
import usePrevious from 'hooks/usePrevious' | ||
import { useCowFromLockedGnoBalances } from 'pages/Profile/LockedGnoVesting/hooks' | ||
import { useCowFromLockedGnoBalances } from '@src/custom/pages/Account/LockedGnoVesting/hooks' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should the imports here (line 27 and 66) be from There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes you're right. I believe this has been fixed in |
||
|
||
const COW_DECIMALS = COW[ChainId.MAINNET].decimals | ||
|
||
|
@@ -250,7 +250,7 @@ export default function Profile() { | |
<ErrorModal /> | ||
|
||
{chainId && chainId === ChainId.MAINNET && <AffiliateStatusCheck />} | ||
<Title>Profile</Title> | ||
<Title>Account</Title> | ||
|
||
<CardsWrapper> | ||
{isCardsLoading ? ( | ||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -20,7 +20,7 @@ const PrivacyPolicy = lazy(() => import(/* webpackChunkName: "privacy_policy" */ | |||||
const CookiePolicy = lazy(() => import(/* webpackChunkName: "cookie_policy" */ 'pages/CookiePolicy')) | ||||||
const TermsAndConditions = lazy(() => import(/* webpackChunkName: "terms" */ 'pages/TermsAndConditions')) | ||||||
const About = lazy(() => import(/* webpackChunkName: "about" */ 'pages/About')) | ||||||
const Profile = lazy(() => import(/* webpackChunkName: "profile" */ 'pages/Profile')) | ||||||
const Account = lazy(() => import(/* webpackChunkName: "profile" */ '@src/custom/pages/Account')) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is how it looks like in the last branch (
Let me know if that should be changed to your suggestion:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah I see. |
||||||
const NotFound = lazy(() => import(/* webpackChunkName: "not_found" */ 'pages/error/NotFound')) | ||||||
const CowRunner = lazy(() => import(/* webpackChunkName: "cow_runner" */ 'pages/games/CowRunner')) | ||||||
const MevSlicer = lazy(() => import(/* webpackChunkName: "mev_slicer" */ 'pages/games/MevSlicer')) | ||||||
|
@@ -94,12 +94,13 @@ export default function App() { | |||||
<Wrapper> | ||||||
<Suspense fallback={Loading}> | ||||||
<Switch> | ||||||
<Redirect from="/claim" to="/profile" /> | ||||||
<Redirect from="/claim" to="/account" /> | ||||||
<Redirect from="/profile" to="/account" /> | ||||||
<Route exact strict path="/swap" component={Swap} /> | ||||||
<Route exact strict path="/swap/:outputCurrency" component={RedirectToSwap} /> | ||||||
<Route exact strict path="/send" component={RedirectPathToSwapOnly} /> | ||||||
<Route exact strict path="/about" component={About} /> | ||||||
<Route exact strict path="/profile" component={Profile} /> | ||||||
<Route exact strict path="/account" component={Account} /> | ||||||
|
||||||
<Route exact path="/faq" component={Faq} /> | ||||||
<Route exact strict path="/faq/protocol" component={ProtocolFaq} /> | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a note here to update the path with @nenadV91 's changes where affiliate has it's own subpath now