-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Alpaka EDProducers to pass the edm::ParameterSet to base class constructor #47216
Migrate Alpaka EDProducers to pass the edm::ParameterSet to base class constructor #47216
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47216/43501
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@Moanwar, @atpathak, @cmsbuild, @consuegs, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @perrotta, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Size: This PR adds an extra 80KB to repository Comparison SummarySummary:
|
+heterogeneous |
enable gpu |
please test |
+1 Size: This PR adds an extra 80KB to repository Comparison SummarySummary:
GPU Comparison SummarySummary:
|
+1 |
+alca
|
@cms-sw/upgrade-l2 Could you review and sign? Thanks! @cms-sw/orp-l2 I'd like to have this PR for pre3, if possible. |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a follow-up to #47028 and migrates all present Alpaka EDProducers to pass the
edm::ParameterSet
to their base class constructor.Resolves cms-sw/framework-team#1189
PR validation:
Code compiles